[PM-34205] fix: Hide unmasked password text field from VO when password is masked#2499
Merged
matt-livefront merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
github-actions
bot
added
app:password-manager
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2499 +/- ##
==========================================
- Coverage 86.90% 85.80% -1.11%
==========================================
Files 1845 2076 +231
Lines 163218 178293 +15075
==========================================
+ Hits 141847 152979 +11132
- Misses 21371 25314 +3943 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
approved these changes
Mar 27, 2026
morganzellers-bw
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34205
📔 Objective
When navigating through a password field with VoiceOver, VoiceOver is reading the text field twice when the password is masked, but it should only be reading it once.
When the password is masked, there's two text fields stacked on top of each other: a regular one and a secure one. The regular one is hidden, but present to maintain spacing. However, since it wasn't hidden from accessibility, VoiceOver was still reading it when the password was masked. This hides the field from VoiceOver.
📸 Screenshots
VO.Password.Field.Before.mov
VO.Password.Field.After.mov