Skip to content

[PM-35271] chore: Provide environment URLs to SDK client via ClientSettings#2561

Merged
matt-livefront merged 1 commit into
mainfrom
matt/PM-35271-sdk-environment-urls
Apr 22, 2026
Merged

[PM-35271] chore: Provide environment URLs to SDK client via ClientSettings#2561
matt-livefront merged 1 commit into
mainfrom
matt/PM-35271-sdk-environment-urls

Conversation

@matt-livefront
Copy link
Copy Markdown
Collaborator

@matt-livefront matt-livefront commented Apr 21, 2026

🎟️ Tracking

PM-35271

📔 Objective

As part of the V2 encryption changes, the SDK is going to start making networking requests previously made by the app. In order to support this, the app needs to expose the environment URLs to the SDK.

When constructing the SDK, the URLs are provided in ClientSettings. This updates DefaultClientBuilder to gather the necessary values and provide a populated ClientSettings to the SDK.

@matt-livefront matt-livefront added the ai-review Request a Claude code review label Apr 21, 2026
@matt-livefront matt-livefront requested a review from a team as a code owner April 21, 2026 19:53
@matt-livefront matt-livefront added the t:tech-debt Change Type - Tech debt label Apr 21, 2026
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the changes that extract DefaultClientBuilder into its own file and populate ClientSettings with environment URLs, device identifier, user agent, client version, and device type. The dependency updates in ServiceContainer are consistent with existing patterns already used elsewhere in that file (e.g., appIDService, userAgentBuilder). The protocol and callers in DefaultClientService and MockClientBuilder were correctly updated to async. No security, correctness, or breaking-change concerns were identified.

Code Review Details

No findings to report.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details16ebdbd5-b294-4d41-b606-65a2844badcf

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.17%. Comparing base (d0cb942) to head (800145c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   87.17%   87.17%   -0.01%     
==========================================
  Files        1885     1886       +1     
  Lines      166564   166583      +19     
==========================================
+ Hits       145199   145213      +14     
- Misses      21365    21370       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit a3d8d81 into main Apr 22, 2026
21 checks passed
@matt-livefront matt-livefront deleted the matt/PM-35271-sdk-environment-urls branch April 22, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants