[PM-35271] chore: Provide environment URLs to SDK client via ClientSettings#2561
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the changes that extract Code Review DetailsNo findings to report. |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
==========================================
- Coverage 87.17% 87.17% -0.01%
==========================================
Files 1885 1886 +1
Lines 166564 166583 +19
==========================================
+ Hits 145199 145213 +14
- Misses 21365 21370 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

🎟️ Tracking
PM-35271
📔 Objective
As part of the V2 encryption changes, the SDK is going to start making networking requests previously made by the app. In order to support this, the app needs to expose the environment URLs to the SDK.
When constructing the SDK, the URLs are provided in
ClientSettings. This updatesDefaultClientBuilderto gather the necessary values and provide a populatedClientSettingsto the SDK.