Update SDK to 02747b1 (2.0.0-4846-c74b7d1)#2575
Merged
Merged
Conversation
github-actions
Bot
added
app:password-manager
LRNcardozoWDF
added
ai-review
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
- Coverage 87.16% 86.08% -1.09%
==========================================
Files 1886 2116 +230
Lines 166723 181621 +14898
==========================================
+ Hits 145331 156348 +11017
- Misses 21392 25273 +3881 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+49
to
+51
| func removeBulk(keys: [String]) async throws { | ||
| for key in keys { | ||
| try await cipherDataStore.deleteCipher(id: key, userId: userId) |
Collaborator
There was a problem hiding this comment.
🎨 This could be slow to delete one-by-one if there's a large number of ciphers being deleted. Would it be worth updating this and setBulk(values:) to use batch requests? Or at the very least create a ticket to follow-up on this since I don't think these are used yet.
Member
Author
There was a problem hiding this comment.
Nice catch, I create a task to deal with this.
github-actions
Bot
added
app:password-manager
matt-livefront
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-35125
📔 Objective
Adapts the iOS client for two breaking changes introduced by the SDK update (2.0.0-4846-c74b7d1):
What's Changed