Skip to content

PM-35200 - Create contributing guide for Claude tooling#2592

Merged
theMickster merged 2 commits into
mainfrom
adding-claude-contribution-guide
Apr 29, 2026
Merged

PM-35200 - Create contributing guide for Claude tooling#2592
theMickster merged 2 commits into
mainfrom
adding-claude-contribution-guide

Conversation

@theMickster
Copy link
Copy Markdown
Contributor

@theMickster theMickster commented Apr 29, 2026

🎟️ Tracking

PM-35200

📔 Objective

Craft guidance for engineers to understand contributing to Claude tooling.
The guidance in the other-side-of-the-coin for ai-plugins/pull/88.

@theMickster theMickster requested review from a team as code owners April 29, 2026 08:05
@theMickster theMickster added the ai-review Request a Claude code review label Apr 29, 2026
@github-actions github-actions Bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a documentation-only change that adds .claude/CONTRIBUTING.md (130 lines) — a guide for engineers contributing Claude tooling to this repo. The guide explains scoping rules (root vs. nested CLAUDE.md, skills, agents, commands, rules), the boundary between repo-specific content and bitwarden/ai-plugins, security conventions for skills/agents that touch vault data, and an iterative authoring workflow. Content is consistent with the existing .claude/ layout and reinforces Bitwarden's zero-knowledge invariant where security-relevant tooling is concerned. No code paths, dependencies, configuration, or runtime behavior are affected.

Code Review Details

No actionable findings. Purely additive Markdown; voice and structure align with the neighboring .claude/CLAUDE.md, links resolve, and scoping guidance is internally consistent. PR title, description, and Jira link are adequate; no test plan needed for a docs-only change.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Logo
Checkmarx One – Scan Summary & Detailsd1344fd8-23b0-409d-b1b7-2a510812f336

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (2373dce) to head (8570720).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
- Coverage   87.17%   86.08%   -1.09%     
==========================================
  Files        1886     2116     +230     
  Lines      166863   181678   +14815     
==========================================
+ Hits       145463   156402   +10939     
- Misses      21400    25276    +3876     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theMickster theMickster merged commit 2ed2b51 into main Apr 29, 2026
20 checks passed
@theMickster theMickster deleted the adding-claude-contribution-guide branch April 29, 2026 15:07
Comment thread .claude/CONTRIBUTING.md

- Run a local Bitwarden Claude Code review with `/bitwarden-code-review:code-review-local` — it
writes findings to files so you can fix them before pushing, without posting anything to GitHub.
- When you raise the PR, apply the `ai-review` label. Our reusable GitHub workflow watches for it
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 @theMickster should it explain when to use ai-review-vnext label as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; I'm not opposed to you altering the document in a PR 😄
In all honesty, the label is intended to be used by the people actively working on code review enhancements so we don't negatively impact the entire organization. I personally am inclined to leave this as-is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants