Skip to content

[BRE-1851] Update the Crowdin API token#2600

Merged
vgrassia merged 2 commits into
mainfrom
bre-1851_update-crowdin-api-token
Apr 30, 2026
Merged

[BRE-1851] Update the Crowdin API token#2600
vgrassia merged 2 commits into
mainfrom
bre-1851_update-crowdin-api-token

Conversation

@vgrassia
Copy link
Copy Markdown
Member

@vgrassia vgrassia commented Apr 30, 2026

🎟️ Tracking

📔 Objective

This PR updates the location of the Crowdin API token.

@vgrassia vgrassia requested a review from a team as a code owner April 30, 2026 18:11
@vgrassia vgrassia added the ai-review Request a Claude code review label Apr 30, 2026
@vgrassia vgrassia enabled auto-merge (squash) April 30, 2026 18:12
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Apr 30, 2026
Copy link
Copy Markdown
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:feelsgood:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR relocates the Crowdin API token from the bitwarden-ci Azure Key Vault to the gh-ios Key Vault for both crowdin-pull.yml and crowdin-push.yml. In crowdin-pull.yml, an additional retrieve-secrets-crowdin step is introduced so the GPG private key and passphrase continue to be pulled from bitwarden-ci while the Crowdin token is fetched from gh-ios. Secret-name casing (CROWDIN-API-TOKEN) and key vault naming (gh-ios) are consistent with the convention used elsewhere in the workflow (BW-GHAPP-ID, BW-GHAPP-KEY from gh-org-bitwarden), and all env var references in the crowdin/github-action invocations correctly point at their respective step outputs.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (b54624f) to head (54b5e48).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2600      +/-   ##
==========================================
- Coverage   87.21%   86.12%   -1.09%     
==========================================
  Files        1895     2120     +225     
  Lines      167767   182352   +14585     
==========================================
+ Hits       146313   157050   +10737     
- Misses      21454    25302    +3848     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgrassia vgrassia merged commit 016f0d6 into main Apr 30, 2026
16 checks passed
@vgrassia vgrassia deleted the bre-1851_update-crowdin-api-token branch April 30, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants