Skip to content

Skip tests on Gemfile* changes#2602

Merged
mpbw2 merged 2 commits into
mainfrom
filter-gemfile-changes
Apr 30, 2026
Merged

Skip tests on Gemfile* changes#2602
mpbw2 merged 2 commits into
mainfrom
filter-gemfile-changes

Conversation

@mpbw2
Copy link
Copy Markdown
Contributor

@mpbw2 mpbw2 commented Apr 30, 2026

📔 Objective

Skip app tests when making changes to Gemfile or Gemfile.lock

@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Apr 30, 2026
@mpbw2 mpbw2 added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 30, 2026
@mpbw2 mpbw2 marked this pull request as ready for review April 30, 2026 20:23
@mpbw2 mpbw2 requested a review from a team as a code owner April 30, 2026 20:23
@mpbw2 mpbw2 enabled auto-merge (squash) April 30, 2026 20:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds Gemfile and Gemfile.lock to the paths-ignore list in .github/workflows/test.yml and .github/workflows/test-bwa.yml, so PRs that only modify Ruby bundler manifests will skip the iOS test workflows. The change is symmetric across both Password Manager and Authenticator test workflows, matches the existing paths-ignore convention, and is appropriately scoped — Gemfile changes affect Fastlane/CI tooling and do not impact the compiled iOS apps.

Code Review Details

No findings. Changes are minimal, correctly placed under the pull_request trigger, and consistent across both workflow files.

@mpbw2 mpbw2 disabled auto-merge April 30, 2026 20:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (3ecf4ce) to head (b679e23).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
- Coverage   87.20%   86.12%   -1.08%     
==========================================
  Files        1894     2120     +226     
  Lines      167519   182319   +14800     
==========================================
+ Hits       146087   157031   +10944     
- Misses      21432    25288    +3856     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpbw2 mpbw2 merged commit d7d18e7 into main Apr 30, 2026
19 checks passed
@mpbw2 mpbw2 deleted the filter-gemfile-changes branch April 30, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants