[PM-36578] test: Fix flaky test_passwordHistoryPublisher in GeneratorRepositoryTests

[KatherineInCode]

🎟️ Tracking

PM-36578

📔 Objective

Fixes a flaky test_passwordHistoryPublisher test in GeneratorRepositoryTests. The old implementation used fire-and-forget Task { } blocks to call addPasswordHistory, then immediately polled with waitFor, creating a race condition in CI. Rewrote the test as async throws using an AsyncIterator, so each add operation is awaited directly before calling iterator.next() — fully sequential, no concurrent tasks, no race conditions. Follows the same pattern already used in GeneratorDataStoreTests.test_passwordHistoryPublisher().

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed PR #2615 which refactors test_passwordHistoryPublisher in GeneratorRepositoryTests to eliminate a CI flake. The change replaces fire-and-forget Task { } blocks plus waitFor polling with sequential await on an AsyncIterator, removing the underlying race condition. The new pattern mirrors the established approach in GeneratorDataStoreTests.test_passwordHistoryPublisher(), the test-only scope is appropriate, and assertions retain equivalent coverage.

Code Review Details

No findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.23%. Comparing base (4047574) to head (eb306d6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2615   +/-   ##
=======================================
  Coverage   87.22%   87.23%           
=======================================
  Files        1899     1899           
  Lines      168083   168073   -10     
=======================================
- Hits       146612   146611    -1     
+ Misses      21471    21462    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.