Skip to content

[PM-35680] chore: Convert SendClientProtocol to AutoMockable#2622

Merged
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-sends
May 8, 2026
Merged

[PM-35680] chore: Convert SendClientProtocol to AutoMockable#2622
matt-livefront merged 1 commit into
mainfrom
matt/PM-35680-sdk-mocks-sends

Conversation

@matt-livefront
Copy link
Copy Markdown
Collaborator

@matt-livefront matt-livefront commented May 8, 2026

🎟️ Tracking

PM-35680

📔 Objective

Updates SendClientProtocol to AutoMockable.

@matt-livefront matt-livefront requested a review from a team as a code owner May 8, 2026 15:52
@matt-livefront matt-livefront added the ai-review Request a Claude code review label May 8, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context labels May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR converts the bespoke MockSendClient to an AutoMockable-generated MockSendClientProtocol, following the same pattern established in PR #2616. The change adds an empty SendClientProtocol extension to BitwardenSdkMocks.swift, removes duplicated hand-written mocks from both BitwardenShared and AuthenticatorShared test helpers, and updates SendRepositoryTests to use AutoMockable-generated properties (encryptReceivedSend, decryptReceivedSend, decryptCallsCount). Default closures in BitwardenShared's MockClientService preserve the prior round-trip encrypt/decrypt behavior so existing tests remain semantically equivalent.

Code Review Details

No findings.

@matt-livefront matt-livefront changed the title [PM-35680] Convert SendClientProtocol to AutoMockable [PM-35680] chore: Convert SendClientProtocol to AutoMockable May 8, 2026
@matt-livefront matt-livefront added the t:tech-debt Change Type - Tech debt label May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (1bc99e4) to head (4cef689).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
- Coverage   87.30%   86.26%   -1.05%     
==========================================
  Files        1900     2125     +225     
  Lines      169233   183729   +14496     
==========================================
+ Hits       147750   158489   +10739     
- Misses      21483    25240    +3757     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 32384f7 into main May 8, 2026
19 of 26 checks passed
@matt-livefront matt-livefront deleted the matt/PM-35680-sdk-mocks-sends branch May 8, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants