[PM-36643] refactor: Extract premium checkout debounce interval to Constants#2632
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR extracts the hardcoded 300 ms debounce interval in Code Review DetailsNo issues found.
|
…val as debounce default
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
==========================================
- Coverage 87.31% 86.27% -1.04%
==========================================
Files 1912 2137 +225
Lines 170379 184896 +14517
==========================================
+ Hits 148759 159512 +10753
- Misses 21620 25384 +3764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Missed this one, thank you! |
There was a problem hiding this comment.
@KatherineInCode looks good only thing missing is fixing the PR labels 👍
🎟️ Tracking
PM-36643
📔 Objective
Extracts the hardcoded 300 ms debounce interval in
DefaultBillingService.premiumCheckoutStatusPublisher()intoConstants.premiumCheckoutStatusDebounceInterval(typed asDispatchQueue.SchedulerTimeType.Stride) and wires it as the default value for the existing injectabledebounceIntervalparameter. Also adds line-wrapping style and magic-number constant guidance to.claude/CLAUDE.md.