[PM-36627] feat: Update upgraded to premium action card#2634
Merged
Conversation
- Replace "View plan details" button (navigating to settings) with "Learn more" button that opens the premium help page via ExternalLinksConstants.learnMoreAboutPremium - Shorten card message to "You now have access to all advanced security features." - Remove unused viewPlanDetails action, route, coordinator case, and localization strings - Add snapshot test for upgraded to premium card state
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
==========================================
- Coverage 87.31% 86.27% -1.04%
==========================================
Files 1912 2137 +225
Lines 170379 184900 +14521
==========================================
+ Hits 148759 159517 +10758
- Misses 21620 25383 +3763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Upgraded to Premium” action card behavior in the Vault list by changing its messaging and switching the CTA from in-app navigation to opening an external help URL, while removing the now-unused internal route and related navigation/test coverage.
Changes:
- Update the action card copy and replace “View plan details” with a “Learn more” button that opens
https://bitwarden.com/help/password-manager-plans/. - Remove the
.viewPlanDetailsroute and coordinator navigation/test that previously switched to Settings → Premium Plan. - Add processor test coverage for the new
.learnMoreAboutPremiumaction and add a (disabled) snapshot test case for the upgraded-to-premium card state.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| BitwardenShared/UI/Vault/Vault/VaultRoute.swift | Removes the .viewPlanDetails route from vault navigation. |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListView.swift | Updates the upgraded-to-premium action card message and CTA to “Learn more” and sends the new action. |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListAction.swift | Replaces viewPlanDetails with learnMoreAboutPremium action. |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessor.swift | Implements the new action by setting state.url to the external Premium plans help link and hiding the card. |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift | Updates unit test to verify URL opening state + card dismissal behavior. |
| BitwardenShared/UI/Vault/Vault/VaultCoordinator.swift | Removes navigation handling for the deleted .viewPlanDetails route. |
| BitwardenShared/UI/Vault/Vault/VaultCoordinatorTests.swift | Removes test for the deleted .viewPlanDetails navigation. |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListView+SnapshotTests.swift | Adds a (disabled) snapshot test case covering the upgraded-to-premium card state. |
| BitwardenResources/Localizations/en.lproj/Localizable.strings | Updates English strings: removes old “View plan details” / welcome text and adds the new shorter message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1081
to
+1084
| "YourUpgradeIsBeingProcessedDescriptionLong" = "Your upgrade is being processed. You'll remain on the free plan until it's complete. Sync now to check, or continue and it will update automatically."; | ||
| "UpgradedToPremium" = "Upgraded to Premium"; | ||
| "YouNowHaveAccessToAdvancedSecurityDescriptionLong" = "You now have access to advanced security features. Learn more about what's included with Premium."; | ||
| "ViewPlanDetails" = "View plan details"; | ||
| "WelcomeToPremiumYouNowHaveAccessDescriptionLong" = "Welcome to Premium! You now have access to all advanced security features."; | ||
| "YouNowHaveAccessToAllAdvancedSecurityFeatures" = "You now have access to all advanced security features."; |
fedemkr
reviewed
May 12, 2026
Contributor
Author
They stack up |
fedemkr
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36627
📔 Objective
Updates the "Upgraded to Premium" action card in the vault list:
viewPlanDetailslocalization strings, action, route, and coordinator case📸 Screenshots