Skip to content

[bre-1909] cleanup migrated workflows#2640

Merged
aj-bw merged 2 commits into
mainfrom
bre-1909/cleanup-migrated-workflows
May 13, 2026
Merged

[bre-1909] cleanup migrated workflows#2640
aj-bw merged 2 commits into
mainfrom
bre-1909/cleanup-migrated-workflows

Conversation

@aj-bw
Copy link
Copy Markdown
Member

@aj-bw aj-bw commented May 13, 2026

🎟️ Tracking

bre-1909

📔 Objective

delete 3 migrated workflows. remove unused fastlane lane as that logic was rewritten to use alttool instead

📸 Screenshots

@aj-bw aj-bw added the ai-review Request a Claude code review label May 13, 2026
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

CI/infrastructure cleanup removing three migrated GitHub Actions workflows (publish-github-release-bwa.yml, publish-github-release-bwpm.yml, publish-store.yml), the upload_build Fastlane lane, and its supporting APPLE_ID_MAP constant. Verified there are no remaining references to any of the deleted workflows, the lane, or the constant in the repository, and that xcrun altool is now invoked directly from _build-any.yml (replacing the old fastlane indirection). The replacement github-release.yml workflow is in place. No application code is affected.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.31%. Comparing base (2f7b45e) to head (5f05ec2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
- Coverage   87.35%   86.31%   -1.04%     
==========================================
  Files        1917     2141     +224     
  Lines      171067   185558   +14491     
==========================================
+ Hits       149438   160170   +10732     
- Misses      21629    25388    +3759     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aj-bw aj-bw marked this pull request as ready for review May 13, 2026 18:57
@aj-bw aj-bw requested review from a team and matt-livefront as code owners May 13, 2026 18:57
@aj-bw aj-bw merged commit 6c7d5cb into main May 13, 2026
18 checks passed
@aj-bw aj-bw deleted the bre-1909/cleanup-migrated-workflows branch May 13, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants