Skip to content

[QA-1865] Removing Rate the app alert for Beta builds#2641

Merged
ifernandezdiaz merged 7 commits into
mainfrom
QA-1865/remove-rate-app-alert-beta-builds
May 15, 2026
Merged

[QA-1865] Removing Rate the app alert for Beta builds#2641
ifernandezdiaz merged 7 commits into
mainfrom
QA-1865/remove-rate-app-alert-beta-builds

Conversation

@ifernandezdiaz
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/QA-1865

📔 Objective

We found the Rate the App alert was causing some false negatives during our nightly e2e runs. This PR aims to prevent this alert from being displayed in beta builds only.

📸 Screenshots

@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label May 13, 2026
@ifernandezdiaz ifernandezdiaz added the t:misc Change Type - ¯\_(ツ)_/¯ label May 13, 2026
Comment thread BitwardenShared/Core/Platform/Services/ReviewPromptService.swift Outdated
Comment thread BitwardenShared/Core/Platform/Services/ServiceContainer.swift Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.35%. Comparing base (da776c0) to head (05cbd82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   87.34%   86.35%   -1.00%     
==========================================
  Files        1920     2143     +223     
  Lines      171137   185513   +14376     
==========================================
+ Hits       149484   160192   +10708     
- Misses      21653    25321    +3668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ifernandezdiaz ifernandezdiaz marked this pull request as ready for review May 13, 2026 14:47
@ifernandezdiaz ifernandezdiaz requested review from a team and matt-livefront as code owners May 13, 2026 14:47
@github-actions github-actions Bot added app:authenticator Bitwarden Authenticator app context and removed t:misc Change Type - ¯\_(ツ)_/¯ labels May 13, 2026
Comment thread BitwardenKit/Core/Platform/Services/AppInfoServiceTests.swift Outdated
Comment thread BitwardenShared/Core/Platform/Services/ReviewPromptService.swift
Comment thread BitwardenShared/Core/Platform/Services/ReviewPromptServiceTests.swift Outdated
@ifernandezdiaz ifernandezdiaz force-pushed the QA-1865/remove-rate-app-alert-beta-builds branch from 206458e to 62daccf Compare May 13, 2026 15:44
@ifernandezdiaz ifernandezdiaz added the t:misc Change Type - ¯\_(ツ)_/¯ label May 13, 2026
Comment thread BitwardenKit/Core/Platform/Services/AppInfoServiceTests.swift
@github-actions github-actions Bot removed the t:misc Change Type - ¯\_(ツ)_/¯ label May 14, 2026
@ifernandezdiaz ifernandezdiaz enabled auto-merge (squash) May 14, 2026 19:12
@ifernandezdiaz ifernandezdiaz added the t:misc Change Type - ¯\_(ツ)_/¯ label May 15, 2026
@github-actions github-actions Bot removed the t:misc Change Type - ¯\_(ツ)_/¯ label May 15, 2026
@ifernandezdiaz ifernandezdiaz merged commit 7f75e9a into main May 15, 2026
16 checks passed
@ifernandezdiaz ifernandezdiaz deleted the QA-1865/remove-rate-app-alert-beta-builds branch May 15, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants