This repository was archived by the owner on May 14, 2025. It is now read-only.
Fix Pin cannot be hidden after showing it #1025#1027
Merged
Conversation
mpbw2
approved these changes
Jul 30, 2020
cscharf
mannequin
deleted the
fix/1025-pin-connect-be-hidden-after-showing-it
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025
Overview
Xamarin Forms handles the scenario where a Numeric keyboard type + IsPassword setting properly sets the native Android Input Type between Numeric vs. NumericPassword. This is overridden by BW's custom entry renderer's implementation which maps custom fonts and behavior for Android.
This change adds the scenario to handle a PIN style (numeric keyboard) which should be masked/password and can be toggled accordingly.