Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Allow alphanumeric card numbers#1097

Merged
kspearrin merged 1 commit intomasterfrom
master
Sep 30, 2020
Merged

Allow alphanumeric card numbers#1097
kspearrin merged 1 commit intomasterfrom
master

Conversation

@TheDuffman85
Copy link
Mannequin

@TheDuffman85 TheDuffman85 mannequin commented Sep 30, 2020

Removed Keyboard="Numeric" property from CardNumberEntry. European debit card numbers are alphanumeric. See also https://en.wikipedia.org/wiki/International_Bank_Account_Number.

Removed Keyboard="Numeric" property from CardNumberEntry. European debit card numbers are alphanumeric. See also https://en.wikipedia.org/wiki/International_Bank_Account_Number.
@CLAassistant
Copy link
Mannequin

CLAassistant mannequin commented Sep 30, 2020

CLA assistant check
All committers have signed the CLA.

@kspearrin
Copy link
Mannequin

kspearrin mannequin commented Sep 30, 2020

Do we need this in other client apps?

@TheDuffman85
Copy link
Mannequin Author

TheDuffman85 mannequin commented Sep 30, 2020

I don't think so. This is a mobile only issue, because the onscreen keyboard is switched to numeric mode. I checked the Windows Client, Firefox Extension and the Web Vault. In all thoose clients you can enter alphanumeric characters just fine.

kspearrin
kspearrin mannequin approved these changes Sep 30, 2020
@kspearrin kspearrin mannequin merged commit fd55cf6 into master Sep 30, 2020
@mmattel
Copy link
Mannequin

mmattel mannequin commented Oct 9, 2020

@kspearrin thanks for linking. When to excpect a rollout with this fix?

@vachan-maker
Copy link
Mannequin

vachan-maker mannequin commented Oct 9, 2020

It is currently available in the beta version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants