This repository was archived by the owner on May 14, 2025. It is now read-only.
[SG-416] Updates to Bitwarden Authenticator#1964
Merged
andrebispo5 merged 56 commits intofeature/feature-totpfrom Jul 26, 2022
Merged
[SG-416] Updates to Bitwarden Authenticator#1964andrebispo5 merged 56 commits intofeature/feature-totpfrom
andrebispo5 merged 56 commits intofeature/feature-totpfrom
Conversation
This reverts commit b02c58e.
# Conflicts: # src/App/App.csproj
# Conflicts: # src/App/Pages/Authenticator/AuthenticatorPage.xaml # src/App/Pages/Authenticator/AuthenticatorPage.xaml.cs # src/App/Pages/Authenticator/AuthenticatorPageViewModel.cs
… details, Added new text resource
…ored circular progress view.
…y text of switch because android was overlapping text.
…en. Changed existing labels on scanner screen.
…Added scan success animation.
# Conflicts: # src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs # src/App/Pages/Vault/ScanPage.xaml.cs
andrebispo5
changed the title
# Conflicts: # src/App/Resources/AppResources.Designer.cs # src/App/Resources/AppResources.resx
fedemkr
changed the title
fedemkr
suggested changes
Jul 8, 2022
Member
fedemkr
left a comment
fedemkr
left a comment
There was a problem hiding this comment.
Great work!! 😄 , here you have some proposed changes to improve the code, let me know if you have any doubts on them
src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml
Outdated
Show resolved
Hide resolved
src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml.cs
Outdated
Show resolved
Hide resolved
src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml
Outdated
Show resolved
Hide resolved
Comment on lines
+2276
to
2278
| <comment>Authenticator TOTP feature</comment> | ||
| </data> | ||
| <data name="Name" xml:space="preserve"> |
Member
There was a problem hiding this comment.
We should coordinate with crowdin updates and when possible update this to have the proper name AuthenticatorKey and update Authenticator Key (TOTP) to have the name AuthenticatorKeyTOTP instead of using the one that would for this. Don't do it ASAP, first talk it through the team.
… it places an helper text next to the switch making it invisible. Also removed from the label because it already reads the text from the label
Member
|
This shouldn't be included in our next release, we'll merge it in a feature branch for the time being. |
# Conflicts: # src/App/Resources/AppResources.Designer.cs # src/App/Resources/AppResources.resx
fedemkr
suggested changes
Jul 18, 2022
Member
fedemkr
left a comment
fedemkr
left a comment
There was a problem hiding this comment.
Great improvements, I've left some more; let me know what you think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Rework on Authenticator UI/UX in order to improve its usability and promote the use of scanner the feature for TOTP setup. Also hoping to clarify the feature differences based on the plan selected.
Code changes
Clients PR: bitwarden/clients#3045
New cell UI to show TOTP code circular progress and cipher info. Will appear on cipher list with TOTP toggle on.
Circular progress control has some properties to customise its appearance. The file also contains some helper classes that are only used here in this control.
In order to make the button with the camera icon and text work, avoiding many forms bugs, i had to create a frame and place an IconLabel inside. There is a bug with the
ButtonViewwhere the text gets clipped.New header to have the toggle for TOTP ciphers. Added new data template to support the authenticator cells.
Changed inherit list type to the generic interface in order to use the
GroupingsPageTOTPListItemin the selector.Added
SKCanvasViewto hold the scanning animation. Also added the new UI to enter the code manually.Added method to draw the scanning squared corners into the
SKCanvasView. The object being drawn gets its size from a global variable_scalethat is calculated based on a Sine function and aStopwatch. Currently it is being drawn by the animation loop at a rate of 1/30 of a second, if we see there is some kind of performance impairment, we can increase this value.Screenshots
New toggle to show only ciphers with TOTP codes:
New list of ciphers with only TOTP codes:
Toast when copy TOTP value:
New QRCode scanning animation, the square corners pulse and turn green when code found also phone vibrates:
New UI to enter the code manually:
Free users won't be able to see the TOTP code, instead helper text is shown:
Premium users will see a circular progress and the TOTP code:
Authentication key when empty, will only show a button the scan a QRCode:
Before you submit
dotnet tool run dotnet-format --check) (required)