Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Auto bump mobile version after release#2013

Merged
michalchecinski merged 10 commits intomasterfrom
feature/DEVOPS-849_autobump_mobile
Aug 2, 2022
Merged

Auto bump mobile version after release#2013
michalchecinski merged 10 commits intomasterfrom
feature/DEVOPS-849_autobump_mobile

Conversation

@michalchecinski
Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add workflow to auto bump mobile version after release. Not tested because Github doesn't detect new workflows from other branches than the default branch.

Code changes

  • .github/workflows/version-auto-bump.yml: Add workflow to auto bump mobile version after release

Screenshots

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

Comment thread .github/workflows/version-auto-bump.yml Outdated
Comment thread .github/workflows/version-auto-bump.yml

((CURR_VER++))
NEW_VER=$CURR_MAJOR$CURR_VER

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for to trigger the version bump workflow with the needed inputs? Similar to how we do it in build-browser.yml?
https://github.com/bitwarden/clients/blob/12bca0a597dada622e23a37830da0c266b0c8048/.github/workflows/build-browser.yml#L348

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea to trigger the version bump workflow from the new auto bump workflow.

Copy link
Copy Markdown
Contributor

@mimartin12 mimartin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer that we can't test with workflow_dispatch without merging into master. 😞

@joseph-flinn
Copy link
Copy Markdown
Contributor

It's a bummer that we can't test with workflow_dispatch without merging into master. 😞

We can merge a stub of this file into master to enable manual testing on the feature branch:

# .github/workflows/version-auto-bump.yml
---
name: Version Auto Bump

on:
  # For testing only
  workflow_dispatch:
    inputs: {}

jobs:

  setup:
    name: "Setup"
    runs-on: ubuntu-20.04
    steps:
      - name: Stub for testing
        run: echo "this is a stub"

@michalchecinski
Copy link
Copy Markdown
Contributor Author

Added PR for the suggested stub: #2015
Thanks @joseph-flinn !

@michalchecinski michalchecinski dismissed a stale review via b41f696 August 1, 2022 09:07
@michalchecinski
Copy link
Copy Markdown
Contributor Author

Workflow tested. Ready for the review :)

@michalchecinski michalchecinski merged commit ee8b886 into master Aug 2, 2022
@michalchecinski michalchecinski deleted the feature/DEVOPS-849_autobump_mobile branch August 2, 2022 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants