This repository was archived by the owner on May 14, 2025. It is now read-only.
Change password generator to use ColoredPassword#686
Merged
Conversation
Mannequin
|
This was intentionally not implemented on this page because it causes performance issues. I don't have a solution at this time. |
Mannequin
Author
|
I see the issue and belive I've found a solution. Using a HTML formatted string seems to have significantly better performance than FormattedString. I see no noticable performance impact now. |
Mannequin
|
Awesome! We can also apply this to the passwords on the password history and password generator history page. |
Mannequin
Author
|
Good suggestions 👍 I'll have those things fixed, and will apply it to the history pages tomorrow. |
Mannequin
Author
|
Used a converter class for the history pages. Looks clean to me, but not sure if there's a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords displayed in the password generator are not colour coded like they are on other platforms. This pull request changes the password generator password to be colour coded.
https://community.bitwarden.com/t/color-coded-password-not-working-on-android/9594