-
Notifications
You must be signed in to change notification settings - Fork 24
build: implement a nix flake #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 65.34% 65.51% +0.17%
==========================================
Files 195 195
Lines 15087 15156 +69
==========================================
+ Hits 9859 9930 +71
+ Misses 5228 5226 -2 ☔ View full report in Codecov by Sentry. |
33344f7 to
8c237c4
Compare
tangowithfoxtrot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! I was able to get the devshell running locally and everything seems to be working.
I just have a few small nits in the documentation.
Co-authored-by: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
|




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14844
📔 Objective
Implement a nix flake for the project. It has a ton of capabilities. Primarily it can:
technologies like rust, android dependencies, etc. Only Xcode is an
exception to this.
environments without installing any software permanently on the building
machine. Build dependencies are garbage collected after use.
development environments painlessly.
These features enable so many QoL improvements to local development and CI that really imagination is the only limiting factor. A few include:
The flake is documented with more detail, including how to get started using it and all of the builds available.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes