Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e2bb9c1
Make context local Ids autogenerated
dani-garcia May 12, 2025
7218aba
Update docs
dani-garcia May 12, 2025
81c7439
Merge branch 'main' into ps/context-local-uuids
dani-garcia Jun 12, 2025
ab25b95
Add comments
dani-garcia Jun 12, 2025
d9707e0
Fix tests
dani-garcia Jun 12, 2025
175dbce
Merge branch 'main' into ps/context-local-uuids
dani-garcia Jun 26, 2025
237cb20
Add signing keys
dani-garcia Jun 26, 2025
d892b90
Merge branch 'main' into ps/context-local-uuids
dani-garcia Jun 30, 2025
7b2b49f
Introduce opaque local ids
dani-garcia Jun 30, 2025
817cf6e
Fmt
dani-garcia Jun 30, 2025
c4cf8ec
Missing docs
dani-garcia Jun 30, 2025
f0c31ed
Merge branch 'main' into ps/context-local-uuids
dani-garcia Aug 19, 2025
b67aaca
Merge branch 'main' into ps/context-local-uuids
dani-garcia Sep 22, 2025
7963cdc
[PM-22591] Unify client repository initialization (#484)
dani-garcia Oct 8, 2025
80fbec9
fix: artifact name (#497)
coroiu Oct 8, 2025
090fc07
Update key-management related CODEOWNERS (#498)
quexten Oct 9, 2025
b505df0
Update API to d2577f670e1cf9ca32791135d2197cff1fe12096 (#491)
bw-ghapp[bot] Oct 9, 2025
1461b3b
[deps]: Update rust Docker tag to v1.89 (#248)
renovate[bot] Oct 9, 2025
41674ea
[PM-25901] Publish Bitwarden-licensed SDK to npm (#496)
coroiu Oct 10, 2025
d584cb6
fix: use correct working directory when publishing (#500)
coroiu Oct 10, 2025
cc36132
PM-26727 Sticky Claude Comments and More Specific prompts
theMickster Oct 10, 2025
11f8ee2
Merge branch 'main' into ps/context-local-uuids
quexten Oct 13, 2025
d37361b
Remove unused imports
quexten Oct 13, 2025
0b58542
Merge branch 'ps/context-local-uuids' into km/data-envelope-follow-up
quexten Oct 22, 2025
99fbb45
Add convenience functions and fix build
quexten Oct 22, 2025
d704375
Fix clippy
quexten Oct 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,13 @@

# Team-owned crates
crates/bitwarden-auth/** @bitwarden/team-auth-dev @bitwarden/team-platform-dev
crates/bitwarden-crypto/** @bitwarden/team-key-management-dev @bitwarden/team-platform-dev @bitwarden/dept-architecture
crates/bitwarden-crypto/** @bitwarden/team-key-management-dev @bitwarden/team-sdk-sme
crates/bitwarden-vault/** @bitwarden/team-vault-dev @bitwarden/team-sdk-sme

# KM Co-owned files
crates/bitwarden-core/src/key_management/** @bitwarden/team-key-management-dev @bitwarden/team-sdk-sme
crates/bitwarden-wasm-internal/src/pure_crypto.rs @bitwarden/team-key-management-dev @bitwarden/team-sdk-sme

# BW CLI
crates/bw/src/admin_console/** @bitwarden/team-platform-dev
crates/bw/src/auth/** @bitwarden/team-auth-dev @bitwarden/team-platform-dev
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-wasm-internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ jobs:
strategy:
matrix:
license_type:
- artifact_name: "wasm-internal"
- artifact_name: "sdk-internal"
build_flags: ""
npm_folder: "npm"
readable: "open source license"
- artifact_name: "commercial-wasm-internal"
- artifact_name: "commercial-sdk-internal"
build_flags: "-b"
npm_folder: "bitwarden_license/npm"
readable: "commercial license"
Expand Down
22 changes: 15 additions & 7 deletions .github/workflows/publish-wasm-internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ on:
description: "Release Version"
required: false

defaults:
run:
working-directory: crates/bitwarden-wasm-internal/npm

jobs:
setup:
name: Setup
Expand Down Expand Up @@ -57,13 +53,23 @@ jobs:
fi

npm:
name: Publish NPM
name: Publish NPM - ${{matrix.license_type.readable}}
environment: NPM
runs-on: ubuntu-24.04
needs: setup
permissions:
contents: read
id-token: write
strategy:
matrix:
license_type:
- artifact_name: "sdk-internal"
npm_folder: "npm"
readable: "open source license"
- artifact_name: "commercial-sdk-internal"
npm_folder: "bitwarden_license/npm"
readable: "commercial license"

steps:
- name: Checkout repo
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -80,15 +86,17 @@ jobs:
workflow: build-wasm-internal.yml
workflow_conclusion: success
branch: ${{ inputs.release_type == 'Dry Run' && 'main' || github.ref_name }}
artifacts: sdk-internal
path: crates/bitwarden-wasm-internal/npm
artifacts: ${{ matrix.license_type.artifact_name }}
path: crates/bitwarden-wasm-internal/${{ matrix.license_type.npm_folder }}

- name: Set version
working-directory: crates/bitwarden-wasm-internal/${{ matrix.license_type.npm_folder }}
run: |
npm version --no-git-tag-version $VERSION
env:
VERSION: ${{needs.setup.outputs.release-version}}

- name: Publish NPM
if: ${{ inputs.release_type != 'Dry Run' }}
working-directory: crates/bitwarden-wasm-internal/${{ matrix.license_type.npm_folder }}
run: npm publish --access public --tag latest
21 changes: 18 additions & 3 deletions .github/workflows/review-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,18 @@ jobs:

- name: Review with Claude Code
if: steps.check_changes.outputs.vault_team_changes == 'true'
uses: anthropics/claude-code-action@a5528eec7426a4f0c9c1ac96018daa53ebd05bc4 # v1.0.7
uses: anthropics/claude-code-action@ac1a3207f3f00b4a37e2f3a6f0935733c7c64651 # v1.0.11
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
track_progress: true
use_sticky_comment: true
prompt: |
REPO: ${{ github.repository }}
PR NUMBER: ${{ github.event.pull_request.number }}
TITLE: ${{ github.event.pull_request.title }}
BODY: ${{ github.event.pull_request.body }}
AUTHOR: ${{ github.event.pull_request.user.login }}
COMMIT: ${{ github.event.pull_request.head.sha }}

Please review this pull request with a focus on:
- Code quality and best practices
Expand All @@ -103,7 +105,20 @@ jobs:

Note: The PR branch is already checked out in the current working directory.

Provide detailed feedback using inline comments for specific issues.
Provide a comprehensive review including:
- Summary of changes since last review
- Critical issues found (be thorough)
- Suggested improvements (be thorough)
- Good practices observed (be concise - list only the most notable items without elaboration)
- Action items for the author
- Leverage collapsible <details> sections where appropriate for lengthy explanations or code snippets to enhance human readability

When reviewing subsequent commits:
- Track status of previously identified issues (fixed/unfixed/reopened)
- Identify NEW problems introduced since last review
- Note if fixes introduced new issues

IMPORTANT: Be comprehensive about issues and improvements. For good practices, be brief - just note what was done well without explaining why or praising excessively.

claude_args: |
--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"
--allowedTools "mcp__github_comment__update_claude_comment,mcp__github_inline_comment__create_inline_comment,Bash(gh pr diff:*),Bash(gh pr view:*)"
11 changes: 1 addition & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ bitwarden-send = { path = "crates/bitwarden-send", version = "=1.0.0" }
bitwarden-sm = { path = "bitwarden_license/bitwarden-sm", version = "=1.0.0" }
bitwarden-ssh = { path = "crates/bitwarden-ssh", version = "=1.0.0" }
bitwarden-state = { path = "crates/bitwarden-state", version = "=1.0.0" }
bitwarden-state-migrations = { path = "crates/bitwarden-state-migrations", version = "=1.0.0" }
bitwarden-test = { path = "crates/bitwarden-test", version = "=1.0.0" }
bitwarden-threading = { path = "crates/bitwarden-threading", version = "=1.0.0" }
bitwarden-uniffi-error = { path = "crates/bitwarden-uniffi-error", version = "=1.0.0" }
Expand Down
23 changes: 18 additions & 5 deletions crates/bitwarden-api-api/.openapi-generator/FILES
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ src/models/bulk_delete_response_model.rs
src/models/bulk_delete_response_model_list_response_model.rs
src/models/bulk_deny_admin_auth_request_request_model.rs
src/models/change_plan_frequency_request.rs
src/models/checkout_billing_address_request.rs
src/models/cipher.rs
src/models/cipher_attachment_model.rs
src/models/cipher_bulk_archive_request_model.rs
Expand Down Expand Up @@ -241,8 +242,10 @@ src/models/key_regeneration_request_model.rs
src/models/keys_request_model.rs
src/models/keys_response_model.rs
src/models/license_type.rs
src/models/master_password_authentication_data_request_model.rs
src/models/master_password_policy_response_model.rs
src/models/master_password_unlock_data_model.rs
src/models/master_password_unlock_and_authentication_data_model.rs
src/models/master_password_unlock_data_request_model.rs
src/models/master_password_unlock_kdf_response_model.rs
src/models/master_password_unlock_response_model.rs
src/models/member_access_detail_report_response_model.rs
Expand Down Expand Up @@ -276,6 +279,7 @@ src/models/organization_integration_configuration_request_model.rs
src/models/organization_integration_configuration_response_model.rs
src/models/organization_integration_request_model.rs
src/models/organization_integration_response_model.rs
src/models/organization_integration_status.rs
src/models/organization_keys_request_model.rs
src/models/organization_keys_response_model.rs
src/models/organization_license.rs
Expand All @@ -295,7 +299,10 @@ src/models/organization_sponsorship_sync_response_model.rs
src/models/organization_sso_request_model.rs
src/models/organization_sso_response_model.rs
src/models/organization_status_type.rs
src/models/organization_subscription_plan_change_request.rs
src/models/organization_subscription_purchase_request.rs
src/models/organization_subscription_response_model.rs
src/models/organization_subscription_update_request.rs
src/models/organization_subscription_update_request_model.rs
src/models/organization_update_request_model.rs
src/models/organization_upgrade_request_model.rs
Expand All @@ -322,13 +329,14 @@ src/models/organization_user_user_details_response_model.rs
src/models/organization_user_user_details_response_model_list_response_model.rs
src/models/organization_user_user_mini_details_response_model.rs
src/models/organization_user_user_mini_details_response_model_list_response_model.rs
src/models/organization_verify_bank_request_model.rs
src/models/organization_verify_delete_recover_request_model.rs
src/models/other_device_keys_update_request_model.rs
src/models/password_health_report_application.rs
src/models/password_health_report_application_model.rs
src/models/password_hint_request_model.rs
src/models/password_manager_plan_features_response_model.rs
src/models/password_manager_purchase_selections.rs
src/models/password_manager_update_selections.rs
src/models/password_request_model.rs
src/models/payment_method_type.rs
src/models/payment_request_model.rs
Expand All @@ -340,6 +348,7 @@ src/models/pending_organization_auth_request_response_model.rs
src/models/pending_organization_auth_request_response_model_list_response_model.rs
src/models/people_access_policies_request_model.rs
src/models/permissions.rs
src/models/plan_cadence_type.rs
src/models/plan_response_model.rs
src/models/plan_response_model_list_response_model.rs
src/models/plan_sponsorship_type.rs
Expand All @@ -355,10 +364,12 @@ src/models/pre_validate_sponsorship_response_model.rs
src/models/premium_cloud_hosted_subscription_request.rs
src/models/preview_individual_invoice_request_body.rs
src/models/preview_organization_invoice_request_body.rs
src/models/preview_tax_amount_for_organization_trial_request_body.rs
src/models/preview_organization_subscription_plan_change_tax_request.rs
src/models/preview_organization_subscription_purchase_tax_request.rs
src/models/preview_organization_subscription_update_tax_request.rs
src/models/preview_premium_subscription_purchase_tax_request.rs
src/models/priority.rs
src/models/product_tier_type.rs
src/models/product_type.rs
src/models/profile_organization_response_model.rs
src/models/profile_organization_response_model_list_response_model.rs
src/models/profile_provider_organization_response_model.rs
Expand Down Expand Up @@ -413,6 +424,7 @@ src/models/push_update_request_model.rs
src/models/request_sm_access_request_model.rs
src/models/reset_password_with_org_id_request_model.rs
src/models/response_data.rs
src/models/restart_subscription_request.rs
src/models/revoke_access_tokens_request.rs
src/models/rotate_user_account_keys_and_data_request_model.rs
src/models/saml2_binding_type.rs
Expand All @@ -429,9 +441,11 @@ src/models/secret_verification_request_model.rs
src/models/secret_with_projects_inner_project.rs
src/models/secret_with_projects_list_response_model.rs
src/models/secrets_manager_plan_features_response_model.rs
src/models/secrets_manager_purchase_selections.rs
src/models/secrets_manager_request_model.rs
src/models/secrets_manager_subscribe_request_model.rs
src/models/secrets_manager_subscription_update_request_model.rs
src/models/secrets_manager_update_selections.rs
src/models/secrets_sync_response_model.rs
src/models/secrets_with_projects_inner_secret.rs
src/models/secure_note_type.rs
Expand Down Expand Up @@ -482,7 +496,6 @@ src/models/sync_response_model.rs
src/models/tax_id_request.rs
src/models/tax_info_response_model.rs
src/models/tax_info_update_request_model.rs
src/models/tax_information_dto.rs
src/models/tax_information_request_body.rs
src/models/tax_information_request_model.rs
src/models/tokenized_payment_method_request.rs
Expand Down
Loading
Loading