Improvements to backup-db.sh/sql to add 4 more features. Allow: Diff dir and suffix. Copy and ln of latest backup #1720
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…the latest MSSQL backup. In favour of snapshots/deduplication algorithms, e.g. restic/other automation circumstances. Facilitate copy and symlink to the of/to the latest MSSQL backup. In favour of snapshots/deduplication algorithms, e.g. restic minimal comment addtion for the last commit fix if comparison in the previous commit fix if comparison ordering in the previous commit Allow different Backup Dir for DB. Facilitate copy and symlink of/to the latest MSSQL backup. In favour of snapshots/deduplication algorithms, e.g. restic/other automation circumstances.
haneef95
changed the title
haneef95
changed the title
|
@haneef95 would you be willing to start a thread here: https://community.bitwarden.com/c/github-contributions/7 ? May be good to lay out what it is exactly you'd like to accomplish as well as any pre-dev feedback from the engineering team 👍 |
Rename variables to match the rest. Also: Allow users to specify both $BACKUP_DB_FILENAME and $BACKUP_DB_FILENAME_SUFFIX backup-db.sh minor syntax fix
Contributor
Author
Contributor
Author
|
@tgreer-bw - Looking forward to your thoughts! Thanks 😄 |
Merged
|
Hi @haneef95 , thank you for the work done so far, and apologies for delay in reaching out. I will pick this up, and track this in our internal board for review. We will get back to you soon. |
Contributor
Author
|
Latest on this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps when executing backups manually, like so:
docker exec -ti -e BACKUP_FILENAME_SUFFIX='_PreUpdate' bitwarden-mssql /backup-db.sh