[PM-1191] collections cannot be managed in family organization

[coroiu]

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fix issue reported by users that org vault is broken after OAVR v2 when using EF.

Fixes #2750

Code changes

EF6 is currently not able to translate LINQ that include selects after group statements (see github issue). Using join let's us bypass this issue.

This new solution is probably a bit faster too so win-win :)

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• If making database changes - make sure you also update Entity Framework queries and/or migrations
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[justindbaur]

@coroiu Maybe I am missing something but isn't this now saying every collection has access groups and users associated to it if ANY do?

I have a group that only has the Default Collection:

But two collection show that they have that group assigned.

[justindbaur]

See above concern

[coroiu]

Nice catch, should be fixed now! Guess I “simplified queries” a bit too much 😅

[justindbaur]

Looks great, thanks.

[cvondra]

If these changes were approved why are they not being pulled into the dev build?

[coroiu]

@cvondra waiting for QA, if vault team has different processes then feel free to merge :)

[cvondra]

@justindbaur any idea on the QA status of this?

[justindbaur]

@coroiu Part of the reason that unified is in beta is because QA doesn't have infrastructure or capacity to test each feature branch right now for EF databases. Since this is an EF change only and I ran it locally we can just merge this.

@cvondra I'm going to merge this now and it will be in the dev tag shortly.

[cvondra]

Latest push to /dev works perfectly.