Skip to content

Reverting TOTP changes from rc branch#3276

Merged
trmartin4 merged 3 commits intorcfrom
PM-2128-revert-totp-changes-from-rc
Sep 16, 2023
Merged

Reverting TOTP changes from rc branch#3276
trmartin4 merged 3 commits intorcfrom
PM-2128-revert-totp-changes-from-rc

Conversation

@trmartin4
Copy link
Copy Markdown
Member

@trmartin4 trmartin4 commented Sep 15, 2023

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Reverting 3 commits that implement PM-2128. The initial implementation of this work assumed that we needed to cache all types of 2FA tokens, not just TOTP tokens. Rather than try to patch this for the release, we are reverting it so that we can have a more complete solution in the next release. The changes will stay in master and be iterated upon there in preparation for the November release.

Code change

  • Reverted changes from 3 commits.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@trmartin4 trmartin4 changed the title PM-2128-revert-totp-changes-from-rc Reverting TOTP changes from rc branch Sep 15, 2023
@trmartin4 trmartin4 marked this pull request as ready for review September 15, 2023 23:02
@trmartin4 trmartin4 requested a review from a team as a code owner September 15, 2023 23:02
Copy link
Copy Markdown
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed reversions. All look correct and match old state before the work started.

@trmartin4 trmartin4 merged commit 6b0d031 into rc Sep 16, 2023
@trmartin4 trmartin4 deleted the PM-2128-revert-totp-changes-from-rc branch September 16, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants