Merged
Conversation
JaredSnider-Bitwarden
approved these changes
Sep 15, 2023
Contributor
JaredSnider-Bitwarden
left a comment
There was a problem hiding this comment.
Reviewed reversions. All look correct and match old state before the work started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Reverting 3 commits that implement PM-2128. The initial implementation of this work assumed that we needed to cache all types of 2FA tokens, not just TOTP tokens. Rather than try to patch this for the release, we are reverting it so that we can have a more complete solution in the next release. The changes will stay in
masterand be iterated upon there in preparation for the November release.Code change
Before you submit
dotnet format --verify-no-changes) (required)