[PM-6977] Migrate to FCM v1 by kspearrin · Pull Request #3917 · bitwarden/server

kspearrin · 2024-03-21T13:02:44Z

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Google is deprecating their legacy FCM endpoints (GCM), so migrate to FCMv1 as outlined by Microsoft:

https://learn.microsoft.com/en-us/azure/notification-hubs/notification-hubs-gcm-to-fcm

Before you submit

Please check for formatting errors (dotnet format --verify-no-changes) (required)
If making database changes - make sure you also update Entity Framework queries and/or migrations
Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team

codecov · 2024-03-21T13:12:04Z

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 37.76%. Comparing base (a17426c) to head (b804669).

Files	Patch %	Lines
...ntations/NotificationHubPushRegistrationService.cs	0.00%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3917      +/-   ##
==========================================
- Coverage   37.77%   37.76%   -0.01%     
==========================================
  Files        1188     1188              
  Lines       57879    57890      +11     
  Branches     5539     5540       +1     
==========================================
  Hits        21861    21861              
- Misses      34990    35001      +11     
  Partials     1028     1028

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

withinfocus

Still needed outside of this PR:

migrating existing installations to NotificationPlatform.FcmV1
setting up the credentials in the Hub

github-actions · 2024-04-19T15:31:01Z

Checkmarx One – Scan Summary & Details – 31ade7a3-515e-49a7-ab05-67c611f6227e

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 141
	CSRF	/src/Admin/AdminConsole/Controllers/ProvidersController.cs: 284
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 145
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 145
	CSRF	/src/Api/Billing/Controllers/ProviderClientsController.cs: 30
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 318
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 318
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 702
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 678
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 891
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 173
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 744
	CSRF	/src/Api/Vault/Controllers/FoldersController.cs: 45
	CSRF	/src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 51
	CSRF	/src/Api/Controllers/UsersController.cs: 22
	CSRF	/src/Api/Controllers/DevicesController.cs: 70
	CSRF	/src/Api/Controllers/DevicesController.cs: 57
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 69
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 49
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 142
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 52
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 148
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 50
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 161
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88
	CSRF	/src/Api/Controllers/CollectionsController.cs: 374
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 150
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 150
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 586
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 433
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 970
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 970
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 726
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 825
	CSRF	/src/Api/Controllers/SettingsController.cs: 36
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 993
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 993
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 313
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 369
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 159
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1027
	CSRF	/src/Api/Controllers/CollectionsController.cs: 303
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 205
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 959
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 688
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 231
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 758
	CSRF	/src/Api/Controllers/CollectionsController.cs: 410
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 191
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 271
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 526
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188
	CSRF	/src/Api/Controllers/CollectionsController.cs: 374
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 539
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 539
	CSRF	/src/Api/Controllers/CollectionsController.cs: 323
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 286
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1047
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 613
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 97
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 164
	CSRF	/src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 308
	CSRF	/src/Admin/AdminConsole/Controllers/ProvidersController.cs: 207
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 303
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 144
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 222
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 288
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 187
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 944
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 944
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 362
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 128
	CSRF	/src/Api/Controllers/CollectionsController.cs: 303
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 669
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 807
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 744
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 403
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 231
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 900
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 858
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 571
	CSRF	/src/Api/Controllers/CollectionsController.cs: 410
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 191
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 271
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 526
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 174
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 408
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 188
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 77
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 114
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 230
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 331
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 85
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 203
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 285
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 50
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 59
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 127
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 66
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 111
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 125
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 889
	CSRF	/src/Identity/Controllers/AccountsController.cs: 50
	CSRF	/src/Identity/Controllers/AccountsController.cs: 72
	CSRF	/src/Api/Controllers/CollectionsController.cs: 156
	CSRF	/src/Api/Controllers/CollectionsController.cs: 187
	CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 64
	CSRF	/src/Api/Controllers/CollectionsController.cs: 196
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 560
	CSRF	/src/Admin/AdminConsole/Controllers/ProviderOrganizationsController.cs: 38
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 130
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 101
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 626
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1047
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 116
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 89
	CSRF	/src/Api/Controllers/CollectionsController.cs: 374
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 75
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 318
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 145
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 59
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 153
	CSRF	/src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 38
	CSRF	/src/Api/SecretsManager/Controllers/ProjectsController.cs: 140
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 114
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 126
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 245
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 79
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 406
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 420
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 65
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 77
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 97
	CSRF	/src/Admin/AdminConsole/Controllers/ProvidersController.cs: 264
	CSRF	/src/Admin/AdminConsole/Controllers/ProvidersController.cs: 240
	CSRF	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 64

More results are available on AST platform

vvolkgang

👍🏾

github-actions · 2024-04-22T20:39:47Z

LaunchDarkly flag references

🔍 1 flag added or modified

Name	Key	Aliases found	Info
FCM V1 Migration	`anh-fcmv1-migration`

This reverts commit dd8d595.

fcmv1 update

4c69127

withinfocus reviewed Mar 21, 2024

View reviewed changes

Merge branch 'main' into fcmv1

5628049

withinfocus changed the title ~~fcmv1 update~~ [PM-6977] Migrate to FCM v1 Mar 21, 2024

Merge branch 'main' into fcmv1

b5f740f

kspearrin marked this pull request as ready for review March 21, 2024 18:18

kspearrin added the needs-qa label Mar 21, 2024

kspearrin and others added 5 commits March 21, 2024 17:24

try without nested data obj

fc8e8a3

Merge branch 'fcmv1' of github.com:bitwarden/server into fcmv1

8d5c909

Merge branch 'main' into fcmv1

8e21dce

type must be a string

8bf244b

Merge branch 'fcmv1' of github.com:bitwarden/server into fcmv1

ff57b2a

kspearrin mentioned this pull request Apr 20, 2024

[PM-7631] Handle new FCMv1 format bitwarden/android#3176

Merged

5 tasks

fcmv1 migration flag

ce7a424

vvolkgang previously approved these changes Apr 22, 2024

View reviewed changes

Merge branch 'main' into fcmv1

b45dc19

kspearrin removed the needs-qa label Apr 22, 2024

github-actions bot added the feature-flag label Apr 22, 2024

lint fixes

d2510df

kspearrin dismissed vvolkgang’s stale review via d2510df April 22, 2024 20:40

fix tests

eb66558

kspearrin enabled auto-merge (squash) April 22, 2024 21:05

kspearrin requested a review from vvolkgang April 22, 2024 21:05

Merge branch 'main' into fcmv1

b804669

vvolkgang approved these changes Apr 23, 2024

View reviewed changes

kspearrin merged commit dd8d595 into main Apr 23, 2024

kspearrin deleted the fcmv1 branch April 23, 2024 11:58

kspearrin added a commit that referenced this pull request Apr 23, 2024

Revert "[PM-6977] Migrate to FCM v1 (#3917)"

ebc1540

This reverts commit dd8d595.

kspearrin added a commit that referenced this pull request Apr 23, 2024

Revert "[PM-6977] Migrate to FCM v1 (#3917)" (#4009)

3c76f48

This reverts commit dd8d595.

kspearrin mentioned this pull request May 2, 2024

[PM-6977] Migrate to FCM v1 (redo) #4046

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-6977] Migrate to FCM v1#3917

[PM-6977] Migrate to FCM v1#3917
kspearrin merged 13 commits intomainfrom
fcmv1

kspearrin commented Mar 21, 2024 •

edited

Loading

Uh oh!

codecov bot commented Mar 21, 2024 •

edited

Loading

Uh oh!

withinfocus left a comment

Uh oh!

github-actions bot commented Apr 19, 2024 •

edited

Loading

Uh oh!

vvolkgang left a comment

Uh oh!

github-actions bot commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kspearrin commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Objective

Before you submit

Uh oh!

codecov bot commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

withinfocus left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues

Uh oh!

vvolkgang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 22, 2024

LaunchDarkly flag references

🔍 1 flag added or modified

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kspearrin commented Mar 21, 2024 •

edited

Loading

codecov bot commented Mar 21, 2024 •

edited

Loading

github-actions bot commented Apr 19, 2024 •

edited

Loading