Remove the feature flag

[cyprain-okeke]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2957

📔 Objective

Remove the Feature flag PM-5864-dollar-threshold

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

LaunchDarkly flag references

❌ 1 flag removed

Name	Key	Aliases found	Info
Aggregated invoices for auto-scaling customers	PM-5864-dollar-threshold		✅ all references removed

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1589291). Learn more about missing BASE report.

Files	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4615   +/-   ##
=======================================
  Coverage        ?   41.85%           
=======================================
  Files           ?     1288           
  Lines           ?    61009           
  Branches        ?     5599           
=======================================
  Hits            ?    25533           
  Misses          ?    34287           
  Partials        ?     1189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cturnbull-bitwarden]

Just one blocking comment!

[cturnbull-bitwarden]

This block was previously only accessible when the feature flag was disabled. With the flag enabled, this block is being skipped in production. Is that intended? The logic is effectively changed by deleting !isPm5864DollarThresholdEnabled &&.

Verify that the original logic if (!isPm5864DollarThresholdEnabled && !invoiceNow) { ... } was intended or not. It's possible that there was a bug before and your changes in this PR fixes that bug.

[github-actions]

Checkmarx One – Scan Summary & Details – cab6b809-5755-4c41-902c-9fc24b8740ed

No New Or Fixed Issues Found