Skip to content

Update logic to handle pull_request_target for Docker builds#5008

Merged
mimartin12 merged 1 commit intomainfrom
BRE-417
Nov 8, 2024
Merged

Update logic to handle pull_request_target for Docker builds#5008
mimartin12 merged 1 commit intomainfrom
BRE-417

Conversation

@mimartin12
Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

Removing the grep and create a conditional based on GITHUB_EVENT_NAME.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- Removing the grep and create a conditional based on GITHUB_EVENT_NAME
@mimartin12 mimartin12 marked this pull request as ready for review November 8, 2024 17:29
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.52%. Comparing base (7cf6742) to head (1a555ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5008   +/-   ##
=======================================
  Coverage   42.52%   42.52%           
=======================================
  Files        1395     1395           
  Lines       64873    64873           
  Branches     5951     5951           
=======================================
  Hits        27589    27589           
  Misses      36058    36058           
  Partials     1226     1226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsdd2e06f0-826c-4043-a1d9-ae6b2aec66ee

No New Or Fixed Issues Found

Copy link
Copy Markdown
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

@mimartin12 mimartin12 merged commit a56f3a5 into main Nov 8, 2024
@mimartin12 mimartin12 deleted the BRE-417 branch November 8, 2024 18:58
cyprain-okeke pushed a commit that referenced this pull request Nov 12, 2024
- Removing the grep and create a conditional based on GITHUB_EVENT_NAME
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
- Removing the grep and create a conditional based on GITHUB_EVENT_NAME
vgrassia pushed a commit to vgrassia/server that referenced this pull request Nov 21, 2024
- Removing the grep and create a conditional based on GITHUB_EVENT_NAME
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants