Skip to content

Conversation

@cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17823

📔 Objective

Acceptance criteria

GIVEN: the user is viewing an organization in the Bitwarden Portal

THEN: there is a feature toggle for admin sponsored families

📸 Screenshots

Uploading Screen Recording 2025-04-02 at 18.46.30.mov…

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from jrmccannon April 2, 2025 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsb3fb5a8b-cdad-4ba4-bdc2-a858164215d3

Great job, no security vulnerabilities found in this Pull Request

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.79%. Comparing base (f7e5759) to head (adc49bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...AdminConsole/Views/Shared/_OrganizationForm.cshtml 0.00% 3 Missing ⚠️
...dminConsole/Controllers/OrganizationsController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5595      +/-   ##
==========================================
+ Coverage   46.57%   49.79%   +3.22%     
==========================================
  Files        1615     1615              
  Lines       73557    73561       +4     
  Branches     6617     6620       +3     
==========================================
+ Hits        34256    36628    +2372     
+ Misses      37869    35440    -2429     
- Partials     1432     1493      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jrmccannon
jrmccannon previously approved these changes Apr 3, 2025
@cyprain-okeke cyprain-okeke removed the request for review from a team April 3, 2025 14:34
@cyprain-okeke cyprain-okeke changed the base branch from PM-17830 to main April 15, 2025 15:43
@cyprain-okeke cyprain-okeke dismissed jrmccannon’s stale review April 15, 2025 15:43

The base branch was changed.

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner April 15, 2025 15:43
@cyprain-okeke cyprain-okeke changed the base branch from main to PM-17830 April 15, 2025 15:44
@cyprain-okeke cyprain-okeke removed the request for review from a team April 15, 2025 15:49
Base automatically changed from PM-17830 to main April 16, 2025 15:28
@sonarqubecloud
Copy link

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyprain-okeke cyprain-okeke merged commit 60e7db7 into main Apr 17, 2025
55 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-17823-Add-feature-toggle-for-admin-sponsored-families-to-admin-portal branch April 17, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants