[PM-19180] Calculate sales tax correctly for sponsored plans

[jonashendrickx]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19180

📔 Objective

Sponsored organizations are created in two steps. The sponsorship is the second step where the familiy organization is converted into a family for enterprise organization which is free. Given how the code is otherwise written in the backend related to sponsorships, this proves rather challenging.

We also know we will still need to continue to charge sales tax correctly if the user buys additional storage. And we need to use the PlanType to correctly determine whether the product is for personal use or business use to apply to correct automatic tax rules in Stripe.

Related: bitwarden/clients#14129

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 738a9a39-d2a7-442e-b5a1-2ec2c41c44d3

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96

[codecov]

Codecov Report

Attention: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (01a08c5) to head (9ae083d).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/Services/Implementations/StripePaymentService.cs	29.03%	20 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5611      +/-   ##
==========================================
+ Coverage   46.71%   46.85%   +0.13%     
==========================================
  Files        1615     1615              
  Lines       73563    73566       +3     
  Branches     6617     6618       +1     
==========================================
+ Hits        34368    34466      +98     
+ Misses      37753    37652     -101     
- Partials     1442     1448       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cyprain-okeke]

Looks Good

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
11.1% Duplication on New Code

See analysis details on SonarQube Cloud