[PM-19128] - Optimize Update Collections

[jrmccannon]

🎟️ Tracking

PM-19128

📔 Objective

This updates the existing sproc to not use merge statements and also adds indices to the join tables CollectionGroup and CollectionUser.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (4b6eac3) to head (53cf47c).
Report is 33 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5626      +/-   ##
==========================================
+ Coverage   45.73%   48.82%   +3.09%     
==========================================
  Files        1603     1603              
  Lines       72659    72659              
  Branches     6507     6507              
==========================================
+ Hits        33229    35479    +2250     
+ Misses      38018    35718    -2300     
- Partials     1412     1462      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 0429025d-fc08-42d9-a539-bcfef8b4aefb

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
84.1% Duplication on New Code

See analysis details on SonarQube Cloud

[shane-melton]

We should look into moving the CollectionRepositoryTests file to AC ownership in the future.

[rkac-bw]

lgtm