Skip to content

Conversation

@BTreston
Copy link
Contributor

@BTreston BTreston commented Apr 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19887

📔 Objective

adds token authorization to InitPendingOrganizationEndpoint.

📸 Screenshots

before:

Screen.Recording.2025-04-15.at.3.33.05.PM.mov

after:

Screen.Recording.2025-04-15.at.3.34.59.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.80%. Comparing base (0b50a18) to head (65bf43b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...le/Services/Implementations/OrganizationService.cs 31.57% 13 Missing ⚠️
...Console/Controllers/OrganizationUsersController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5643      +/-   ##
==========================================
- Coverage   45.80%   45.80%   -0.01%     
==========================================
  Files        1609     1609              
  Lines       73170    73189      +19     
  Branches     6556     6560       +4     
==========================================
+ Hits        33516    33522       +6     
- Misses      38226    38238      +12     
- Partials     1428     1429       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BTreston BTreston marked this pull request as ready for review April 11, 2025 14:13
@BTreston BTreston requested a review from a team as a code owner April 11, 2025 14:14
@BTreston BTreston requested a review from JimmyVo16 April 11, 2025 14:14
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc2646155-c111-45ab-966d-7142639df9a8

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston merged commit f678e3d into main Apr 15, 2025
53 checks passed
@BTreston BTreston deleted the ac/pm-19887-authorization-for-initPendingOrganization branch April 15, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants