[PM-21281] Email TOTP sent twice when user only has Email MFA enabled

[ike-kottlowski]

🎟️ Tracking

PM-21281

📔 Objective

With the new two factor component refactors on the client we now send an email automatically when a user selects the email 2 factor option. Historically the server would assume and send an email automatically if email two factor was the only available option to the user. The team opted to not have the server make assumptions about what the client wishes to do and instead wait for instruction from the client.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – e5e9da52-b545-4402-b090-0b63e653c96d

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	Use_Of_Hardcoded_Password	/util/Seeder/Factories/UserSeeder.cs: 14

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (e465f2e) to head (fc371e2).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5782      +/-   ##
==========================================
- Coverage   47.25%   47.19%   -0.07%     
==========================================
  Files        1648     1646       -2     
  Lines       75061    75004      -57     
  Branches     6779     6781       +2     
==========================================
- Hits        35470    35398      -72     
- Misses      38107    38123      +16     
+ Partials     1484     1483       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Patrick-Pimentel-Bitwarden]

👍 Good catch and good work! Thanks for keeping your eyes peeled for stuff like this.