Skip to content

[PM-18064] Resolve billing warnings#5797

Merged
justindbaur merged 5 commits intomainfrom
billing/pm-18064/resolve-billing-warnings
May 9, 2025
Merged

[PM-18064] Resolve billing warnings#5797
justindbaur merged 5 commits intomainfrom
billing/pm-18064/resolve-billing-warnings

Conversation

@justindbaur
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18064

📔 Objective

Fix all billing related warnings.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner May 9, 2025 14:30
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsa3602df8-f319-4d28-967f-3c6da7cb986a

Great job, no security vulnerabilities found in this Pull Request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (2918d46) to head (9642579).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lling/Controllers/OrganizationBillingController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5797      +/-   ##
==========================================
- Coverage   50.39%   47.19%   -3.20%     
==========================================
  Files        1646     1646              
  Lines       75008    75008              
  Branches     6782     6782              
==========================================
- Hits        37797    35400    -2397     
- Misses      35665    38124    +2459     
+ Partials     1546     1484      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justindbaur justindbaur merged commit 0075a15 into main May 9, 2025
53 checks passed
@justindbaur justindbaur deleted the billing/pm-18064/resolve-billing-warnings branch May 9, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants