Skip to content

Conversation

@justindbaur
Copy link
Member

@justindbaur justindbaur commented May 23, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21941

📔 Objective

This is an experiment of running unified as a single process in a single container, hopefully lowering hardware requirements even more.

Goals

  • Runs as a single process inside a container, which means docker logs will be able to view the logs
  • Needs minimal special casing, allows teams to continue to develop the broader application in the same way they've been doing it.
  • Requires fewer resources than the existing unified
  • Most importantly, all the features work.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.73%. Comparing base (652da96) to head (40476bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5861   +/-   ##
=======================================
  Coverage   50.73%   50.73%           
=======================================
  Files        1869     1869           
  Lines       82798    82798           
  Branches     7322     7322           
=======================================
  Hits        42004    42004           
  Misses      39191    39191           
  Partials     1603     1603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Logo
Checkmarx One – Scan Summary & Details673f8a0d-58a4-4687-8100-ceaf66f4d017

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 210
detailsMethod RevokeSponsorship at line 210 of /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs gets a parameter from a user request fr...
ID: BkM1qiT6IRYGVxsWJH6rlzE9NZo%3D
Attack Vector
Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 109
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 274
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 135
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 210

Co-authored-by: tangowithfoxtrot <5676771+tangowithfoxtrot@users.noreply.github.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants