[BEEEP] Fix all CA2254 occurrences#6357
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6357 +/- ##
==========================================
+ Coverage 50.04% 54.27% +4.23%
==========================================
Files 1832 1832
Lines 81531 81530 -1
Branches 7226 7225 -1
==========================================
+ Hits 40800 44254 +3454
+ Misses 39162 35622 -3540
- Partials 1569 1654 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
|
justindbaur
requested review from
Jingo88,
addisonbeck,
ike-kottlowski and
r-tome
harr1424
approved these changes
Sep 22, 2025
r-tome
approved these changes
Sep 24, 2025
Jingo88
approved these changes
Sep 25, 2025
addisonbeck
approved these changes
Sep 29, 2025
JaredSnider-Bitwarden
approved these changes
Oct 20, 2025
Contributor
JaredSnider-Bitwarden
left a comment
JaredSnider-Bitwarden
left a comment
There was a problem hiding this comment.
Auth file changes LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Start enforcing CA2254 at a warning level, which makes it an error effectively. Then fix all occurrences of us not obeying this rule.
I also made sure the two sibling rules are reporting as suggestions, these are a bit less important but I will probably eventually make a large PR fixing these as well.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes