Skip to content

Conversation

@vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22434

📔 Objective

Removing CreateDefaultLocation feature flag references to enable usage on Sefl-hosted instances

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vincentsalucci vincentsalucci self-assigned this Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One – Scan Summary & Detailsba2271c7-d1b5-45cb-be61-e867ff81dfb9

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.94%. Comparing base (2442d2d) to head (ce7ac0e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Tools/Controllers/OrganizationExportController.cs 0.00% 8 Missing ⚠️
src/Api/Vault/Controllers/CiphersController.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6758   +/-   ##
=======================================
  Coverage   54.94%   54.94%           
=======================================
  Files        1927     1927           
  Lines       85480    85457   -23     
  Branches     7653     7648    -5     
=======================================
- Hits        46963    46952   -11     
+ Misses      36729    36718   -11     
+ Partials     1788     1787    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vincentsalucci vincentsalucci marked this pull request as ready for review December 19, 2025 17:37
@vincentsalucci vincentsalucci requested review from a team as code owners December 19, 2025 17:37
@vincentsalucci vincentsalucci merged commit 35868c2 into main Jan 5, 2026
45 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-22434/remove-create-default-location-ff-refs branch January 5, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants