Skip to content

Conversation

@Patrick-Pimentel-Bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31636

📔 Objective

  1. Add salt to the emergency access takeover response for use by the client to separate out salt form email.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden changed the title Auth/pm 31636/emergency access takeover salt feat(emergency-access): [PM-31636] Emergency Access Takeover Salt (#6939) Feb 3, 2026
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden changed the title feat(emergency-access): [PM-31636] Emergency Access Takeover Salt (#6939) feat(emergency-access): [PM-31636] Emergency Access Takeover Salt Feb 3, 2026
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as ready for review February 3, 2026 02:12
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden requested a review from a team as a code owner February 3, 2026 02:12
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.01%. Comparing base (0e72257) to head (c4a601a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6939      +/-   ##
==========================================
+ Coverage   56.05%   60.01%   +3.96%     
==========================================
  Files        1971     1971              
  Lines       87054    87063       +9     
  Branches     7758     7760       +2     
==========================================
+ Hits        48795    52253    +3458     
+ Misses      36452    32914    -3538     
- Partials     1807     1896      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Logo
Checkmarx One – Scan Summary & Details86439563-c3bb-4b17-8aea-cd8957f92d23

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants