feat(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance#6940
Merged
Patrick-Pimentel-Bitwarden merged 8 commits intomainfrom Mar 12, 2026
Merged
Conversation
…ptance - Initial implementation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
…tance - Changes in a good place. Need to write tests.
…ptance - Service tests have been added.
…tance - Fixed comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6940 +/- ##
==========================================
+ Coverage 57.43% 57.44% +0.01%
==========================================
Files 2032 2032
Lines 89377 89406 +29
Branches 7944 7950 +6
==========================================
+ Hits 51331 51361 +30
+ Misses 36203 36202 -1
Partials 1843 1843 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ike-kottlowski
approved these changes
Mar 11, 2026
sven-bitwarden
approved these changes
Mar 12, 2026
|
prograhamming
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ptance (#6940) * feat(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Initial implementation * fix(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Changes in a good place. Need to write tests. * test(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Service tests have been added. * fix(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Fixed comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29585
📔 Objective
📸 Screenshots
What is being tested in order:
I missed the accept state but the logic is right next to the other two states and we'll have QA test it.
Screen.Recording.2026-03-11.at.2.40.35.PM.mov
What is being tested in order:
I missed the accept state but the logic is right next to the other two states and we'll have QA test it.
Screen.Recording.2026-03-11.at.2.49.31.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes