Skip to content

feat(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance#6940

Merged
Patrick-Pimentel-Bitwarden merged 8 commits intomainfrom
auth/pm-29585/prevent-new-emergency-access
Mar 12, 2026
Merged

feat(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance#6940
Patrick-Pimentel-Bitwarden merged 8 commits intomainfrom
auth/pm-29585/prevent-new-emergency-access

Conversation

@Patrick-Pimentel-Bitwarden
Copy link
Copy Markdown
Contributor

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden commented Feb 3, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29585

📔 Objective

  1. Added in logic to prevent invitations while in an organization with auto confirm and in a confirmed/accepted/revoked state.
  2. Added in logic to prevent accepting invitations while in an organization with auto confirm and in a confirmed/accepted/revoked state.
  3. Added requirement level tests for checking the quality of the policies.
  4. Added service level tests for checking the integration of the policy requirement.

📸 Screenshots

What is being tested in order:

  1. Grantor can invite users to emergency access
  2. Invite Grantor to organization with auto confirm policy
  3. Grantor can invite users to emergency access
  4. Grantor accepts invite to organization (invite state)
  5. Grantor accepts org invite
  6. Grantor cannot invite users to emergency access (accept state)
  7. Granor is revoked
  8. Grantor cannot invite users to emergency access (revoked state)

I missed the accept state but the logic is right next to the other two states and we'll have QA test it.

Screen.Recording.2026-03-11.at.2.40.35.PM.mov

What is being tested in order:

  1. Grantor invites Grantee to emergency access
  2. Grantee can accept emergency access invite
  3. Invite Grantee to organization with auto confirm policy
  4. Grantee can accept emergency access invite (invite state)
  5. Grantee accepts org invite
  6. Grantee cannot accept emergency access invite (accept state)
  7. Grantee is revoked
  8. Grantee cannot accept emergency access invite (revoked state)

I missed the accept state but the logic is right next to the other two states and we'll have QA test it.

Screen.Recording.2026-03-11.at.2.49.31.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

Logo
Checkmarx One – Scan Summary & Detailsc6e6a659-362e-4c1f-bdac-c6710662be16

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.44%. Comparing base (20d94c3) to head (02d5cfd).
⚠️ Report is 132 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6940      +/-   ##
==========================================
+ Coverage   57.43%   57.44%   +0.01%     
==========================================
  Files        2032     2032              
  Lines       89377    89406      +29     
  Branches     7944     7950       +6     
==========================================
+ Hits        51331    51361      +30     
+ Misses      36203    36202       -1     
  Partials     1843     1843              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden enabled auto-merge (squash) March 12, 2026 16:30
@sonarqubecloud
Copy link
Copy Markdown

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden merged commit e0a0871 into main Mar 12, 2026
40 checks passed
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden deleted the auth/pm-29585/prevent-new-emergency-access branch March 12, 2026 16:48
prograhamming pushed a commit that referenced this pull request Mar 16, 2026
…ptance (#6940)

* feat(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Initial implementation

* fix(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Changes in a good place. Need to write tests.

* test(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Service tests have been added.

* fix(emergency-access): [PM-29585] Prevent New EA Invitations or Acceptance - Fixed comment.
@djsmith85 djsmith85 added the t:feature Change Type - Feature Development label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants