Skip to content

Require password when seeding a new user#6978

Merged
MGibson1 merged 2 commits intomainfrom
arch/accept-password-in-single-user-seeder
Feb 10, 2026
Merged

Require password when seeding a new user#6978
MGibson1 merged 2 commits intomainfrom
arch/accept-password-in-single-user-seeder

Conversation

@MGibson1
Copy link
Copy Markdown
Member

📔 Objective

Adds password as a required parameter to SingleUserScene seed requests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@MGibson1 MGibson1 enabled auto-merge (squash) February 10, 2026 17:54
theMickster
theMickster previously approved these changes Feb 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

Logo
Checkmarx One – Scan Summary & Detailsede6cdf6-2390-4081-8a04-53ccd487a629

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link
Copy Markdown

@MGibson1 MGibson1 merged commit 902be7d into main Feb 10, 2026
43 checks passed
@MGibson1 MGibson1 deleted the arch/accept-password-in-single-user-seeder branch February 10, 2026 19:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.26%. Comparing base (81e3044) to head (5faff57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6978   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files        1983     1983           
  Lines       87651    87651           
  Branches     7815     7815           
=======================================
  Hits        49318    49318           
  Misses      36503    36503           
  Partials     1830     1830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hinton added a commit to bitwarden/sdk-internal that referenced this pull request Feb 16, 2026
## 🎟️ Tracking

<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->

Resolves breaking change introduced by
bitwarden/server#6978
gbubemismith pushed a commit to bitwarden/sdk-internal that referenced this pull request Feb 25, 2026
## 🎟️ Tracking

<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->

Resolves breaking change introduced by
bitwarden/server#6978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants