Skip to content

[PM-31820] added a null check to the id/partial route#7066

Merged
Jingo88 merged 2 commits intomainfrom
PM-31820-partial-route-add-null
Mar 12, 2026
Merged

[PM-31820] added a null check to the id/partial route#7066
Jingo88 merged 2 commits intomainfrom
PM-31820-partial-route-add-null

Conversation

@Jingo88
Copy link
Copy Markdown
Contributor

@Jingo88 Jingo88 commented Feb 24, 2026

🎟️ Tracking

PM-31820
VULN-383

📔 Objective

User could previously target a cipher they do not have edit access to and add a favorites or folder value for themselves. Adding null check to prevent this use case.

Screen Recordings in ticket

@Jingo88 Jingo88 requested a review from a team as a code owner February 24, 2026 17:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 24, 2026

Logo
Checkmarx One – Scan Summary & Detailsf10bb27b-872c-41d8-b3df-9f98d412f5c2

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.43%. Comparing base (3b9db31) to head (2f04a5c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7066   +/-   ##
=======================================
  Coverage   57.43%   57.43%           
=======================================
  Files        2032     2032           
  Lines       89377    89381    +4     
  Branches     7944     7945    +1     
=======================================
+ Hits        51332    51335    +3     
- Misses      36202    36203    +1     
  Partials     1843     1843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@Jingo88 Jingo88 removed the needs-qa label Mar 12, 2026
@Jingo88 Jingo88 merged commit fe3a8c2 into main Mar 12, 2026
42 of 43 checks passed
@Jingo88 Jingo88 deleted the PM-31820-partial-route-add-null branch March 12, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants