Conversation
|
Claude finished @jrmccannon's task in 5m 16s —— View job I'll analyze this and get back to you. |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
+ Coverage 57.39% 61.50% +4.10%
==========================================
Files 2031 2032 +1
Lines 89273 89394 +121
Branches 7935 7944 +9
==========================================
+ Hits 51235 54978 +3743
+ Misses 36195 32491 -3704
- Partials 1843 1925 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Infrastructure.EntityFramework/AdminConsole/Repositories/OrganizationRepository.cs
Outdated
Show resolved
Hide resolved
JimmyVo16
left a comment
There was a problem hiding this comment.
Some small questions, but overall it looks good.
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs
Outdated
Show resolved
Hide resolved
|
|
Nice work on the view and per-ID sproc. This is a solid foundation. One question though: is FusionCache part of this change, like the org abilities example in CACHING.md, or is that happening in a follow-up? The reason I ask is the current bulk Organization_ReadAbilities only runs around ~1K times per hour. If callers move to per-ID lookups without a cache layer in front of it, that likely turns into something closer to 500–700K DB round trips per hour based on current sync and cipher volume. With FusionCache and stampede protection, that should stay much closer to ~10–15K per hour since you only pay once per unique org per TTL window. |
FusionCache is a later update we will be making. |
Thanks! Makes sense. Is the plan to have FusionCache wired up before the caller migration PRs (#7202, |
Yes, we’re going to migrate to FusionCache and eventually move away from The PRs that you posted will call the new interfaces, but the underlying implementations will still use the existing cache. It will not trigger a database call if they’re not in the cache, since We have future tickets that will change the implementation to call per request ID and cache it appropriately with FusionCache. |





🎟️ Tracking
PM-32066
📔 Objective
This adds a dedicated SQL View for the Organization Ability. This includes a new repository method and integration tests validating it correctly maps those fields. It will be used in future stories.