Skip to content

[PM-32067] - Add Provider Ability View#7200

Open
jrmccannon wants to merge 4 commits intomainfrom
jmccannon/ac/pm-32067-add-provider-ability
Open

[PM-32067] - Add Provider Ability View#7200
jrmccannon wants to merge 4 commits intomainfrom
jmccannon/ac/pm-32067-add-provider-ability

Conversation

@jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Mar 11, 2026

🎟️ Tracking

PM-32067

📔 Objective

This adds Provider Ability View, repository methods, stored procedure and tests for the new cache to use.

@jrmccannon jrmccannon requested review from a team as code owners March 11, 2026 19:21
@jrmccannon jrmccannon requested a review from JimmyVo16 March 11, 2026 19:21
@jrmccannon jrmccannon added the ai-review Request a Claude code review label Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.83%. Comparing base (005c744) to head (a9a951c).

Files with missing lines Patch % Lines
...rk/AdminConsole/Repositories/ProviderRepository.cs 0.00% 13 Missing ⚠️
...er/AdminConsole/Repositories/ProviderRepository.cs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
+ Coverage   57.72%   61.83%   +4.11%     
==========================================
  Files        2042     2042              
  Lines       89817    89838      +21     
  Branches     7985     7986       +1     
==========================================
+ Hits        51845    55553    +3708     
+ Misses      36114    32345    -3769     
- Partials     1858     1940      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Logo
Checkmarx One – Scan Summary & Detailscc1847b5-1c8e-4adf-933f-54f457b6c8db


New Issues (2) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1592
detailsMethod at line 1592 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
2 MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1419
detailsMethod at line 1419 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector

Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 293

JimmyVo16
JimmyVo16 previously approved these changes Mar 11, 2026
@@ -0,0 +1,8 @@
CREATE VIEW [dbo].[ProviderAbilityView]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is this view necessary? We already have a view called ProviderView that contains all of the columns in the Provider table. Can you just select the columns you need from ProviderView in your stored procedure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done according to our contributing docs.

@jrmccannon jrmccannon requested a review from mkincaid-bw March 17, 2026 23:56
mkincaid-bw
mkincaid-bw previously approved these changes Mar 18, 2026
@jrmccannon jrmccannon dismissed stale reviews from mkincaid-bw and JimmyVo16 via 486fd04 March 20, 2026 16:40
@claude
Copy link
Contributor

claude bot commented Mar 20, 2026

Claude finished @jrmccannon's task in 1m 48s —— View job


Code Review: PR #7200 — Add Provider Ability View

  • Gather context and read changed files
  • Review all changed files for issues
  • Post findings and summary

Overall Assessment: APPROVE

This PR adds a new GetAbilityAsync(Guid id) method to the IProviderRepository interface with implementations in both Dapper and Entity Framework, backed by a new ProviderAbilityView SQL view and Provider_ReadAbilityById stored procedure. The implementations follow established repository patterns in the codebase, the SQL uses parameterized queries via stored procedures, and the migration script is idempotent with CREATE OR ALTER. Unit tests cover the ProviderAbility constructor mapping.

Code Review Details

No findings. The code is consistent with existing patterns, the Dapper and EF implementations align on projected columns, and the migration is safe.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants