Skip to content

[PM-4128] Remove nullability of Send.Data and Send.Keys#7266

Open
harr1424 wants to merge 1 commit intomainfrom
PM-4128-Tools-Remove-nullability-of-Send.Data-and-Send.Keys
Open

[PM-4128] Remove nullability of Send.Data and Send.Keys#7266
harr1424 wants to merge 1 commit intomainfrom
PM-4128-Tools-Remove-nullability-of-Send.Data-and-Send.Keys

Conversation

@harr1424
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-4128

📔 Objective

While MSSQL already enforces that Send.Data and Send.Key are not nullable, the Send entity has been updated to reflect this and EF migration scripts have been generated.

Note that as opposed to adding the required keyword to the now non-nullable properties, they are assigned a default initial value of empty string, this is ephemeral as the server will assign the key sent in the client request and assemble the JSON data from non-null components of the same request.

See related PR #7212

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details21c3b113-4ef2-4cce-95f2-5e1402088a44

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (5aae028) to head (c18ca53).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7266      +/-   ##
==========================================
+ Coverage   57.62%   61.75%   +4.13%     
==========================================
  Files        2033     2033              
  Lines       89619    89619              
  Branches     7978     7978              
==========================================
+ Hits        51642    55346    +3704     
+ Misses      36117    32331    -3786     
- Partials     1860     1942      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants