[PM-31736] User-friendly cookie vendor error message#7270
Open
dereknance wants to merge 1 commit intomainfrom
Open
[PM-31736] User-friendly cookie vendor error message#7270dereknance wants to merge 1 commit intomainfrom
dereknance wants to merge 1 commit intomainfrom
Conversation
|
Contributor
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7270 +/- ##
==========================================
- Coverage 61.84% 57.73% -4.12%
==========================================
Files 2042 2042
Lines 89817 89836 +19
Branches 7985 7985
==========================================
- Hits 55548 51864 -3684
- Misses 32329 36114 +3785
+ Partials 1940 1858 -82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-31736
📔 Objective
The SSO cookie vendor endpoint produced responses that were not very user-friendly. This PR sends those messages to the log instead, and responds simply with an HTTP status code as an error code and asks the user to return to the app and try again.