PM-33964 - Fix silent switch defaults in Seeder with fail-fast throws#7277
PM-33964 - Fix silent switch defaults in Seeder with fail-fast throws#7277theMickster merged 1 commit intomainfrom
Conversation
|
Overall Assessment: APPROVE This PR replaces 12 silent All changes are confined to Code Review DetailsNo findings. The changes are mechanical, behavior-preserving, and well-scoped. |
|
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7277 +/- ##
==========================================
- Coverage 57.72% 57.72% -0.01%
==========================================
Files 2042 2042
Lines 89817 89817
Branches 7985 7985
==========================================
- Hits 51845 51844 -1
- Misses 36114 36115 +1
Partials 1858 1858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|




🎟️ Tracking
PM-33964
📔 Objective
Enforce the Seeder's default: throw rule by replacing 12 silent
_ =>fallbacks across 6 files with explicit throw statements, preventing future enum or string additions from silently producing incorrect data. Three IdentityDataGenerator switches that were actively hit by MiddleEast, Africa, and Global regions now have explicit cases preserving the original behavior before the throw guard. One intentional fallback inPlanFeatures.cs(covering 20+ legacy plan types) was documented with a comment rather than changed.