Skip to content

[PM-19143] Fix custom permissions not persisting via InviteOrganizationUsersCommand#7285

Merged
r-tome merged 1 commit intomainfrom
ac/pm-19143/fix-custom-permissions-bug
Mar 24, 2026
Merged

[PM-19143] Fix custom permissions not persisting via InviteOrganizationUsersCommand#7285
r-tome merged 1 commit intomainfrom
ac/pm-19143/fix-custom-permissions-bug

Conversation

@r-tome
Copy link
Copy Markdown
Contributor

@r-tome r-tome commented Mar 24, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19143

📔 Objective

MapToDataModel was not calling SetPermissions() on the OrganizationUser entity, so custom permissions were never written to the database when inviting through POST /public/members with the feature flag enabled. Adds the missing call and strengthens the integration test to cover permissions.

@r-tome r-tome marked this pull request as ready for review March 24, 2026 11:38
@r-tome r-tome requested a review from a team as a code owner March 24, 2026 11:38
@r-tome r-tome requested a review from sven-bitwarden March 24, 2026 11:38
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details0455d850-30ea-4007-a0e5-fbbca544efa4

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.85%. Comparing base (524c545) to head (47b2ca5).
⚠️ Report is 139 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7285   +/-   ##
=======================================
  Coverage   57.84%   57.85%           
=======================================
  Files        2043     2043           
  Lines       89868    89875    +7     
  Branches     7989     7990    +1     
=======================================
+ Hits        51984    51993    +9     
+ Misses      36025    36024    -1     
+ Partials     1859     1858    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome merged commit 7c05036 into main Mar 24, 2026
44 checks passed
@r-tome r-tome deleted the ac/pm-19143/fix-custom-permissions-bug branch March 24, 2026 14:12
@djsmith85 djsmith85 added the t:bugfix Change Type - Bugfix label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants