Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7303 +/- ##
=========================================
+ Coverage 0 57.89% +57.89%
=========================================
Files 0 2044 +2044
Lines 0 90068 +90068
Branches 0 8011 +8011
=========================================
+ Hits 0 52148 +52148
- Misses 0 36057 +36057
- Partials 0 1863 +1863 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Overall Assessment: APPROVE This PR fixes a regression from PR 7242 where the Code Review DetailsNo findings identified. The implementation is clean, follows established authorization handler patterns in this codebase, and includes appropriate documentation marking this as a temporary workaround to be removed when PM-34092 is resolved. |
|




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34049
📔 Objective
Fix for #7242, which added Authorize attributes to the
PoliciesController.GetMasterPasswordPolicywas updated to use theMemberRequirement, which assumes a confirmed member. This seemed appropriate because the member was being checked by UserId + OrgId, which matches a confirmed state. However, due to the invalid OrganizationUser provisioning bug, it actually matches invited users who need to set their password as well.I have reverted the previous code, but moved it into an Authorize attribute in order to satisfy the tests (and more recent practices) of using attributes for authorization. This includes detailed xmldoc to explain this.
📸 Screenshots