Skip to content

[PM-33901] Remove unused UpdateTaxInformation#7320

Merged
cturnbull-bitwarden merged 1 commit intomainfrom
billing/PM-33901/remove-update-tax-information
Mar 27, 2026
Merged

[PM-33901] Remove unused UpdateTaxInformation#7320
cturnbull-bitwarden merged 1 commit intomainfrom
billing/PM-33901/remove-update-tax-information

Conversation

@cturnbull-bitwarden
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33901

📔 Objective

Remove dead code: UpdateTaxInformation has no callers in src/. Removes the method from ISubscriberService, SubscriberService, and associated tests. Also removes the now-unused ITaxService constructor parameter from SubscriberService.

@cturnbull-bitwarden cturnbull-bitwarden added the ai-review-vnext Request a Claude code review using the vNext workflow label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Logo
Checkmarx One – Scan Summary & Details94d44a74-a91e-44be-b914-1e81adfaf0e5


Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/VNext/OrganizationBillingVNextController.cs: 107

@cturnbull-bitwarden cturnbull-bitwarden marked this pull request as ready for review March 26, 2026 20:23
@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner March 26, 2026 20:23
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.92%. Comparing base (5833e34) to head (e85e451).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7320      +/-   ##
==========================================
+ Coverage   57.91%   57.92%   +0.01%     
==========================================
  Files        2045     2045              
  Lines       90235    90129     -106     
  Branches     8024     8005      -19     
==========================================
- Hits        52263    52211      -52     
+ Misses      36105    36058      -47     
+ Partials     1867     1860       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cturnbull-bitwarden cturnbull-bitwarden removed the ai-review-vnext Request a Claude code review using the vNext workflow label Mar 27, 2026
UpdateTaxInformation has no callers in src/. Remove from ISubscriberService,
SubscriberService, and associated tests. Also removes the now-unused
ITaxService constructor parameter from SubscriberService.
@cturnbull-bitwarden cturnbull-bitwarden force-pushed the billing/PM-33901/remove-update-tax-information branch from bd0ada9 to e85e451 Compare March 27, 2026 14:43
@sonarqubecloud
Copy link
Copy Markdown

@cturnbull-bitwarden cturnbull-bitwarden merged commit 7458eba into main Mar 27, 2026
48 of 50 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-33901/remove-update-tax-information branch March 27, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants