[PM-33901] Remove unused UpdateTaxInformation#7320
Merged
cturnbull-bitwarden merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7320 +/- ##
==========================================
+ Coverage 57.91% 57.92% +0.01%
==========================================
Files 2045 2045
Lines 90235 90129 -106
Branches 8024 8005 -19
==========================================
- Hits 52263 52211 -52
+ Misses 36105 36058 -47
+ Partials 1867 1860 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UpdateTaxInformation has no callers in src/. Remove from ISubscriberService, SubscriberService, and associated tests. Also removes the now-unused ITaxService constructor parameter from SubscriberService.
bd0ada9 to
e85e451
Compare
|
amorask-bitwarden
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33901
📔 Objective
Remove dead code:
UpdateTaxInformationhas no callers insrc/. Removes the method fromISubscriberService,SubscriberService, and associated tests. Also removes the now-unusedITaxServiceconstructor parameter fromSubscriberService.