[PM-30185] Fix email fallback logic to ignore empty primary email#7359
Merged
[PM-30185] Fix email fallback logic to ignore empty primary email#7359
Conversation
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
jrmccannon
requested changes
Mar 30, 2026
Contributor
jrmccannon
left a comment
jrmccannon
left a comment
There was a problem hiding this comment.
Could we add a test with the "bad" request and validate that it doesn't throw an error and email is populated?
jrmccannon
approved these changes
Mar 30, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7359 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 2054 2054
Lines 90558 90558
Branches 8050 8050
=======================================
Hits 52579 52579
Misses 36112 36112
Partials 1867 1867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eliykat
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30185
📔 Objective
Changes email fallback logic in SCIM invite to ignore the blank primary email if a valid secondary email is provided
📸 Screenshots