[PM-34462] Improve role handling in provider controllers#7372
Merged
Conversation
eliykat
commented
Apr 1, 2026
Member
Author
There was a problem hiding this comment.
Changes in this file were required to get Sqlite working. It doesn't support the LinqToDb.Tools In and NotIn. This is never run on EF in prod (it's cloud only), but is required for integration tests.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7372 +/- ##
==========================================
+ Coverage 58.14% 62.35% +4.20%
==========================================
Files 2055 2055
Lines 90778 90787 +9
Branches 8059 8061 +2
==========================================
+ Hits 52784 56610 +3826
+ Misses 36123 32224 -3899
- Partials 1871 1953 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
jrmccannon
approved these changes
Apr 1, 2026
JaredScar
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34462
📔 Objective
Refactor provider controllers to improve role handling and make sure we have test coverage.
📸 Screenshots