[PM-33897] Schedule Aware Cancellation and Reinstatement#7374
Merged
sbrown-livefront merged 14 commits intomainfrom Apr 2, 2026
Merged
Conversation
…-and-reinstatement
…-and-reinstatement
Contributor
|
Claude finished @sbrown-livefront's task in 4m 15s —— View job Code Review: PM-33897 Schedule Aware Cancellation and Reinstatement
Assessment: ✅ APPROVENo actionable findings. The implementation is well-structured and the previous review feedback from @amorask-bitwarden has been addressed in the latest commits. Key observations:
|
sbrown-livefront
changed the title
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7374 +/- ##
==========================================
+ Coverage 58.23% 58.31% +0.07%
==========================================
Files 2060 2060
Lines 90965 91088 +123
Branches 8085 8093 +8
==========================================
+ Hits 52977 53114 +137
+ Misses 36115 36098 -17
- Partials 1873 1876 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
amorask-bitwarden
left a comment
amorask-bitwarden
left a comment
There was a problem hiding this comment.
Looking good - just a few ⛏️ and questions.
…-and-reinstatement
…-and-reinstatement
|
amorask-bitwarden
approved these changes
Apr 2, 2026
sbrown-livefront
deleted the
billing/pm-33897/schedule-aware-cancellation-and-reinstatement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33897
📔 Objective
Introduces enhancements to the subscription cancellation and reinstatement workflows to support deferred price migration, gated behind the
PM32645_DeferPriceMigrationToRenewalfeature flag. The main changes involve updating how subscription schedules are managed during cancellation and reinstatement, ensuring that price migration logic is correctly applied and reversible.