[PM-34582] Include schedule discount in premium tax estimate#7385
Merged
cturnbull-bitwarden merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7385 +/- ##
=======================================
Coverage 58.43% 58.44%
=======================================
Files 2060 2060
Lines 91173 91178 +5
Branches 8112 8114 +2
=======================================
+ Hits 53281 53287 +6
+ Misses 36003 36002 -1
Partials 1889 1889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When a subscription has an active schedule during the ~15-day window before renewal, the invoice preview for tax estimation was built with the new price but without the Phase 2 discount coupon. This caused the estimated tax on the subscription page to be higher than what Stripe would actually charge. Pass the coupon ID from the schedule's Phase 2 discount through to EstimatePremiumTaxAsync so it is included in the InvoiceCreatePreviewOptions.
cturnbull-bitwarden
force-pushed
the
billing/PM-34582/fix-schedule-tax-estimate
branch
from
c53ebfc to
c620b39
Compare
Contributor
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR fixes a tax estimation discrepancy for premium subscriptions on legacy pricing with an active Phase 2 schedule discount. The Code Review DetailsNo findings. The tuple approach cleanly separates the frontend-facing |
amorask-bitwarden
approved these changes
Apr 3, 2026
|
cturnbull-bitwarden
deleted the
billing/PM-34582/fix-schedule-tax-estimate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34582
📔 Objective
When a Premium subscription has an active schedule during the ~15-day window before renewal, the estimated tax on the subscription page was computed against the full new price without accounting for the Phase 2 discount coupon (e.g.,
milestone-2c). This caused a discrepancy between the tax shown in the Bitwarden UI and what Stripe would actually charge at renewal.The fix passes the Phase 2 coupon ID through to the invoice preview so Stripe computes tax on the discounted amount, matching the actual renewal charge.
Changes:
GetSchedulePhase2DiscountAsyncnow returns both theBitwardenDiscountand the Stripe coupon IDEstimatePremiumTaxAsyncincludes the coupon inInvoiceCreatePreviewOptions.Discountswhen present